Re: Why are multiple revisions allowed in submissions

Hello,

Friday, January 2, 2004, 6:17:21 PM, Kevin Dalley wrote:

> The function db_read allows multiple revision lines (# Revision: n).
> DBFORMAT seems to allow only one revision string.

> Being nice to users is fine, but I favor being strict with the client
> programs and making the follow the defined format.  I believe that the
> responses to a "cddb read" request removes the extra lines, if they
> have not been removed during the submission process.  Thus, clients
> don't have to know how to handle non-standard files.

For a submission with multiple revision lines, only the last line is
taken into account and the file written to the database will only
contain one revision line.
The only case in which this doesn't work is for a "# Revision: " line
with no Revision number following - probably because it is not
recognized as a revision comment, but treated as a normal, meaningless
comment line.

> I did find two files in the database with doubled revision lines.
> Both of them had one blank revision in addition to one numbered
> revision. 

Can you give genre/discid, so I can fix them?

> Are there any known clients which submit files with multiple revision
> lines?

No, I don't know any - If I knew such clients, I would have notified
the authors about the bug.

Best regards, Joerg