Re: Why are multiple revisions allowed in submissions

Joerg Hevers <[email protected]> writes:

> For a submission with multiple revision lines, only the last line is
> taken into account and the file written to the database will only
> contain one revision line.
> The only case in which this doesn't work is for a "# Revision: " line
> with no Revision number following - probably because it is not
> recognized as a revision comment, but treated as a normal, meaningless
> comment line.
>
>> I did find two files in the database with doubled revision lines.
>> Both of them had one blank revision in addition to one numbered
>> revision. 
>
> Can you give genre/discid, so I can fix them?
>
Here are the bad files:

rock/e40f1f10
classical/430f5a15


>> Are there any known clients which submit files with multiple revision
>> lines?
>
> No, I don't know any - If I knew such clients, I would have notified
> the authors about the bug.

Why not refuse to accept submissions from a client which gives two
revisions?  That would strongly encourage clients to behave, and make
cddbd's behavior more predictable.


-- 
Kevin Dalley
[email protected]