Re: Possible memory leak in Icecast-2.4-beta3

"Thomas B. Rücker" <[email protected]> Sun, 12 Jan 2014 22:01:47 +0000

Newsgroups	gmane.comp.audio.icecast.devel
Message-ID	<[email protected]>

Hi everyone,

thanks for everyone's help and persistence!
We've been successful in finding a memory leak (hopefully /the/ memory leak). The main credit goes to Philipp for taking the Valgrind hints and then digging through the pretty awful part of the code and then fixing it:

Author: ph3-der-loewe
Date: 2014-01-12 13:09:04 -0800 (Sun, 12 Jan 2014)
New Revision: 19054

Modified:
   icecast/trunk/icecast/src/format_ogg.c
   icecast/trunk/icecast/src/refbuf.c
Log:
fixed(?) a memory leak: lost headers of stream because of wrong ref counter in associated refbuf objects. I HATE refbuf.



This was a major step towards release, I'll try to roll a beta4/RC1 ASAP. Feel free to test the fix on trunk meanwhile (we also need to confirm we didn't regress in metadata handling).

Cheers

Thomas