Re: python-shout 0.2.1 with icecast 2.4.0 segfaults

Hi there,

that really seems to be the issue here. I've quickly created a new sdist
package for python-shout and installed it with the diff applied into my
virtual environment and the broadcasting seems to work just fine again.

So I can confirm this to solve the issue. Hopefully they accept Bug Fixes
fast so everyone could profit from this.

Thanks


On Mon, Jul 21, 2014 at 2:49 PM, "Thomas B. Rücker" <[email protected]>
wrote:

> Hi,
>
> On 07/18/2014 07:33 PM, Frank Lazzarini wrote:
> > Hi there,
> >
> > I am trying to use python-shout 0.2.1 to broadcast to a icecast 2.4.0
> > server, which result in a segmentation fault and I can't understand
> > why. Is anyone else experiencing this problem?
> […]
> > # ./env/bin/python example.py test.mp3
> > Using libshout version 2.3.1
> > opening file test.mp3
> > Segmentation fault
> >
>
> As I'm not very well versed with those things it took me a bit, but I
> eventually dug out the problem. Something changed in python 2.5 (sic!),
> that broke the PyArg_ParseTuple call in shout.c
> (https://docs.python.org/2/c-api/arg.html#PyArg_ParseTuple).
>
> Below is a diff of a quick-fix that works for me. Before I commit that
> and roll a release, I'd like to hear though from someone well versed in
> those things if it's the right-thing™ to do.
>
> ----------------------------------
> Index: shout.c
> ===================================================================
> --- shout.c (revision 19173)
> +++ shout.c (working copy)
> @@ -19,6 +19,7 @@
> * $Id$
> */
>
> +#define PY_SSIZE_T_CLEAN
> #include <Python.h>
> #include <shout/shout.h>
>
> ----------------------------------
>
>
> Cheers
>
> Thomas
> _______________________________________________
> Icecast-dev mailing list
> [email protected]
> http://lists.xiph.org/mailman/listinfo/icecast-dev
>



-- 

*Frank Lazzarini*
*Email:* [email protected]  *Phone:* +352 621 314 430
*Blog:*   http://www.gefoo.org   *LinkedIn:*
http://www.linkedin.com/pub/frank-lazzarini/1a/a30/112

_______________________________________________
Icecast-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/icecast-dev