Re: Patch for session filename

Emmanuel,

    This was looking real good - right up until I hit the diff for
state.h ;-)  Those changes need to be made to mk-stateh.pl instead of
state.h.  The file state.h is generated by mk-stateh.pl using
state-vars.txt.  Other than that it looks OK.  I'm assuming that you
made the changes to mk-stateh.pl but did the diff on state.h.  I did the
changes to mk-stateh.pl by hand and am going to release that as 0.96.02.

    Just so you'll know while you're working on the followup to this
patch, in the next few days I may be making some rather substantial
changes to hdeq.c.  I'm thinking of trying to remove the XOR graphics
for the signal display part so we'll be more in tune with some of the
newer WMs.

Jan
 

On Sun, 2007-05-13 at 13:03 +0200, Emmanuel Saracco wrote:
> Hi,
> 
> Here is a little patch to have a session filename management more
> consistent IMHO.
> 
> This patch is needed for the second patch I will send (if this one is
> accepted). My second patch will be intented to use gtk_file_chooser_*
> instead of gtk_file_selection_* when GTK+ >= 2.4. But to do that we must
> have a dynamically allocated global session filename (this current patch
> make it possible):
> 
> * Renamed "filename" -> "session_filename".
> 
> * Renamed "s_*_filename()" -> "s_*_session_filename()".
> 
> * Added cleanup in "quit_clean()" for "session_filename".
> 
> * Always use "s_get/set_session_filename()" to manipulate
> "session_filename" variable.
> 
> Tell me if it is ok for you. If so, I will send the second patch.
> 
> Thanks,
> 
> Bye
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________ Jamin-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jamin-devel
-- 
Jan 'Evil Twin' Depner
http://myweb.cableone.net/eviltwin69

"Life should NOT be a journey to the grave with the intention of 
arriving safely in an attractive and well preserved body, but rather to 
skid in sideways, chardonnay in one hand, chocolate in the other, body 
thoroughly used up, totally worn out, and screaming 'WOO HOO, what a ride'"


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/