Re: Patch for compressor history undo/redo

Emmanuel Saracco <[email protected]>
Newsgroups gmane.comp.audio.jamin.devel
Message-ID <1179545010.4021.28.camel@localhost>
Le vendredi 18 mai 2007 à 21:31 -0500, Jan Depner a écrit :

> Emmanuel,

Hi,

In fact it seems that I misunderstood the way undo/redo works in JAMin.

So my patch should be a regression... If so, just forgot it.

>     Sorry, I haven't had a chance to look at this.  Take a look at the
> way the scenes work.  I can't remember if that is tied in with the undo
> stuff or not.  If it isn't then we probably don't need the undo/redo
> functionality.   If it is, then we really only need the scene button
> part to work.  The way I normally do things is to set things and then
> save to a scene.  If I change it some more I can either save to a
> different scene, save to the current scene, or just click on the scene
> button (which becomes yellow on almost any change to the GUI) and it
> will revert back to what is was last "set" to (green state).  There are
> so many options with the scene buttons that we can probably remove the
> undo/redo buttons in the menu (I had forgotten that they were there ;-)

Perhaps should we optimize their use by enabling/disabling them when
needed (avoiding actual segfault). Perhaps also there is some undo/redo
enhancements to do. But I think those buttons are handy.

>     I'll be unable to work on any of this for about 10 days but I should
> be able to get my email so I'll try to keep track of what's going on.
> Thanks again for stepping up and helping out.

Sorry for the noise.

Thanks,

Bye

> On Fri, 2007-05-18 at 01:15 +0200, Emmanuel Saracco wrote:
> > Hi,
> > 
> > Here is the compressor history undo/redo final patch. I think it is
> > stable. Please, give it a try.
> > 
> > ----------
> > -> "jam-ui.glade" file has changed, so you must reedit it with Glade and
> > rebuild the project before building the application.
> > 
> > -> "callbacks.[h,c]" has changed.
> > 
> > -> "mk-stateh.pl" file has changed.
> > ----------
> > 
> > If you accept to commit this patch I will continue working on a history
> > undo/redo management for the equalizer. It seems to be harder to well
> > managed it, but I will try.



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jamin-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jamin-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.