Re: [PATCH] Spectrum views enhancement & small eq fixes

On Wed, 2008-02-27 at 01:05 +0100, Raphaël Doursenaud wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> This small patch against current CVS fixes a few annoyances I got for a
> long time with JAMin.
> 
> 1) Relabeled geq sliders with correct frequency.
> 

    I have no idea what the "correct" frequencies are.  Neither what we
have now nor what you have done matches any 31 band GEQ I've ever seen.
I'll wait for Steve to chime in on that one ;-)  One of the reasons for
not using 31.5 and 1k25 and 3k15, etc. was to save screen real estate.
We really don't need to be exact anyway.  I'm more concerned about
completely eating up every square mm of screen space.


> 2) Correctly calculate tooltip frequency from new geq labels.
> 

    This is more important than the labels.  I'd rather be exact with
the tooltips since they don't use up space.


> 3) Correct spectrum view frequency labels.
> 

    Same as above.


> 4) Accurate frequency display in spectrum view (fixes bug #1736245).
> 

    Same as other above ;-)


> 5) Same on hdeq display. As a side effect, removed rising/decaying display.
> Plan to reintroduce it in a more flexible manner later.
> 

    I'll wait for your more flexible patch to include any of this.  I
don't think we want to remove a feature without providing a replacement.


> 6) Fix for "pen tool" measurement induced by new hdeq display.
> 
> Accuracy of spectrum displays and measurements has been tested with the
> excellent japa & jaaa as sound generators and display references.
> This is my first C code ever. Please review, comment or commit ;)

    I really like the locale fixes for decimal display in callbacks.c.
I had no idea how to do that.  On looking through your patch I see that
you have made changes to jam-ui.glade but also to interface.c.  That
file should not ever be hand edited since it is generated by glade-2
from the jam-ui.glade file.  I'm assuming you used glade-2 to modify the
jam-ui.glade file.

    It's good to see more people getting interested in this.  If you'll
address the interface.c issue and finish the decaying display work we
can look at including this.

    Good job on your first C code.  What do you normally program in?


-- 
Jan 'Evil Twin' Depner
http://www.thecfband.com


"Microsoft has a new version out, Windows XP, which according to
everybody is the 'most reliable Windows ever.' To me, this is like
saying that asparagus is 'the most articulate vegetable ever.'"

Dave Barry



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/