Re: multiple crashes in lame

Am Thu, 29 Jun 2017 13:38:32 +0000 (UTC)
schrieb eblanca76 via Lame-dev <[email protected]>: 

> Different point of view here.
> I think this is the right time for lame to get rid of mpglib,
> following the old rule of "doing one thing, and doing it well".

I do not oppose that. It's only that LAME folks adapted the mpglib to
do more things than just decoding (checking what the encoder produced
with some more insight). If we consider LAME rather finished now, the
need for these changes in mpglib might not be present anymore, or
interested people could port them into a stand-alone tool for
developers only.

> Lame encodes audio into layer3 bitstreams, period.

… and `mpg123 -s input.mpg | lame` re-encodes MPEG audio layer 1/2/3
into layer 3 bitstreams. I'd be fine with that (or `mpg123 -w tmp.wav
input.mpg && lame tmp.wav output.mp3`, of course).

> On the other hand, the same level of features may be achieved using
> libsndfile, now that layer3 encoding is not encumbered by patents
> anymore and that library is going to support mpeg decoding. See
> https://github.com/erikd/libsndfile/issues/258

Ah, finally! I faintly remember prodding Eric in the past (twice), but
he's too busy for replies or I just hopped into the spam folder. As
libsndfile is a lib for reading and writing and likely to end up
linking against lame itself for encoding, I would like to avoid lame
depending on libsndfile in return, though. As a distro maintainer, I
hate circular dependencies.

I didn't bother with a private github account yet (as I don't use it),
so I cannot comment to the libsndfile issue, I presume. I just feel a
little urge to remind people that libmpg123 also does fixed-point math
if you choose that kind of build and does it considerably faster than
libmad … you can choose between plain ARM and also NEON assembly with
proper floating point output, too (reminds me: would lame accept 32 bit
float input at some point?).

> Finally, IMHO lame should not concern about mpeg decoding, both
> mpg123 and madplay are already there, doing the same job.

+1 May need a major version bump to make it clear that feature set
changed.


Alrighty then,

Thomas
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Lame-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lame-dev