Re: New LAME release: 3.100
Fabian Greffrath <[email protected]> Fri, 20 Oct 2017 20:21:32 +0200
| Newsgroups | gmane.comp.audio.mp3.lame |
|---|---|
| Message-ID | <[email protected]> |
Hi there,
congrats to the new release!
1) There are a few patches left that I still apply to the Debian
package:
https://anonscm.debian.org/cgit/pkg-multimedia/lame.git/tree/debian/patches
The first three patches are left-over from the previous release, the
two spelling-error* patches are new in this release (i.e. the spelling
errors have just been detected in this package).
Would you guys please consider applying these?
2) "autoreconf -vif" emits a number of warnings. Most of the are
dupliactes of this
'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
The others are thrown by aclocal and libtoolize, respectively:
aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.in,
libtoolize: and rerunning libtoolize and aclocal.
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
3) It is inconvenient that auto-generated files such as */Makefile.in
are distributed as part of the release tarball. We re-generate these
files as part of the packaging process (see above) and this leads to a
pretty huge but meaningless interdiff between the pristine source
release and the package source.
4) The libmp3lame.so library calls exit(-1) in
libmp3lame/{vbr,}quantize.c which it shouldn't not do, because this
would kill the entire process calling the affected functions.
Cheers,
- Fabian
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot