Re: [patch v2] external MPEG audio decoding using libmpg123

Thomas Orgis <[email protected]> Sat, 15 Sep 2018 12:26:32 +0200
Newsgroups gmane.comp.audio.mp3.lame
Message-ID <20180915122632.56b4ca45@klammerschelle>
Hi, thanks for testing!

Am Sat, 15 Sep 2018 00:57:10 +0200
schrieb Elio Blanca via Lame-dev <[email protected]>: 

> aclocal: warning: autoconf input should be named 'configure.ac', not
> 'configure.in' automake: warning: autoconf input should be named
> 'configure.ac', not 'configure.in' configure.in:1248: warning:
> 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

I am not fixing up lame's deprecated use of the autotools with the
libmp123 patch. The autotools complain, but it still works. This is the
task of another patch.

> The blocking point raised at decoding, when I run:
> 
> topolinik@hp-home:/tmp/lametest.nA5WS/lame/frontend$ ./lame --verbose
> --decode ~/Scrivania/Giovanni\ Sarani/GiovanniSarani-Liminale.mp3
> output_1.wav
> Error opening MPEG input
> file /home/topolinik/Scrivania/Giovanni
> Sarani/GiovanniSarani-Liminale.mp3. Can't init infile
> '/home/topolinik/Scrivania/Giovanni Sarani/GiovanniSarani-Liminale.mp3'

Interesting. I used your variant of the script to build a patched lame
just now and decoding seems to work fine. I usually tested recoding to
mp3, but this works, too:

/tmp/lametest.znQAR/lame/frontend/lame --decode r_e_m/1992_automatic_for_the_people/03-the_sidewinder_sleeps_tonite.mp3 test.wav
input:  r_e_m/1992_automatic_for_the_people/03-the_sidewinder_sleeps_tonite.mp3
	(44.1 kHz, 2 channels, MPEG-1 Layer III)
output: test.wav  (16 bit, Microsoft WAVE)
skipping initial 1105 samples (encoder+decoder delay)
skipping final 803 samples (encoder padding-decoder delay)
Frame#  9549/9549    32 kbps   MS            

To have a common comparison, I'm also trying it on the reference files.
Does this play for you?

shell$ svn export svn://scm.orgis.org/mpg123/test/compliance/layer3/compl.bit compl.mp3
shell$ ./lame --decode compl.mp3 test.wav
input:  compl.mp3  (48 kHz, 1 channel, MPEG-1 Layer III)
output: test.wav  (16 bit, Microsoft WAVE)
skipping initial 529 samples (encoder+decoder delay)
Frame#   216/217     64 kbps                 

(Lame refuses opening with the original file name.)

My testing is on an Intel Atom x7 x86-64 device with Ubuntu 18.04.1 LTS,
if that matters.


Alrighty then,

Thomas