Is reporting bugs good here?

"T.Takahra via Lame-dev" <[email protected]> Sat, 4 Apr 2020 20:36:42 +0900
Newsgroups gmane.comp.audio.mp3.lame
Message-ID <[email protected]>
I downloaded "lame-3.100.tar.gz".
And I tried to compile it, but couldn't.

(1)
I modified the following two files to compile:

[lame.h]
0047>(old)  #define DEPRECATED_OR_OBSOLETE_CODE_REMOVED 1
0047>(new)  #define DEPRECATED_OR_OBSOLETE_CODE_REMOVED 0

[lametime.c]
0131>        int
0132>        lame_set_stream_binary_mode(FILE * const fp)
0133>        {
0134>        #if   defined __EMX__
0135>            _fsetmode(fp, "b");
0136>        #elif defined __BORLANDC__
0137>            setmode(_fileno(fp), O_BINARY);
0138>        #elif defined __CYGWIN__
0139>(old)       setmode(fileno(fp), _O_BINARY);
0139>(new)       setmode(fileno(fp), 0);
0140>        #elif defined _WIN32
0141>(old)       _setmode(_fileno(fp), _O_BINARY);
0141>(new)       _setmode(_fileno(fp), 0);
0142>        #else
0143>            (void) fp; /* doing nothing here, silencing the compiler only. */
0144>        #endif
0145>            return 0;
0146>        }

I am happy with this change.
However, some people may have problems as well as me.

I think the files currently being distributed should be modified.

The environment I compiled is shown below.

Microsoft Windows [Version 10.0.18363.752]
CYGWIN_NT-10.0 DESKTOP-JDMRC20 3.1.4 (0.340 / 5/3)
    2020-02-19 08:49 x86_64 Cygwin


(2)
I have another problem report.

The code in the folder "vc_solution" cannot be compiled with the current
"Visual Studio Community 2019 Version 16.5.2, Visual C ++ 2019
00435-60000-00000-AA907".

Is it possible to change to an environment that can be compiled with current
Visual Studio?



-----[The following is in Japanese. You can safely ignore]-----
lame-3.100.tar.gz


[lame.h]
[lametime.c]




Microsoft Windows [Version 10.0.18363.752]
CYGWIN_NT-10.0 DESKTOP-JDMRC20 3.1.4(0.340/5/3) 2020-02-19 08:49 x86_64 Cygwin

vc_solutionVisual Studio Community 2019
Version 16.5.2, Visual C++ 2019   00435-60000-00000-AA907

Visual Studio
-----


--
T.Takahra <[email protected]>