Perf patches, libmpg123 patches, and a new release of LAME?

Hi,

In the FreeBSD bugtracker  
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246175) Daniel  
Engbert (CCed) provided patches for LAME in the FreeBSD Ports  
Collection to add some of the changes we have in LAME-SVN but not in a  
release, and additionally integrated some performenace optimisations.

My reaction as a FreeBSD-guy to this was to close the FreeBSD bug  
report due to the fact that I only track the official LAME release in  
the FreeBSD Ports Collection.

But this is not the reaction I shall do with my LAME-hat on.

1. perf patches:
Do we have someone with some SSE knowledge here who could review  
https://tmkk.undo.jp/lame/lame-3.100-sse-20171014.diff? I had a look  
at it, the SSE part is out of my comfort zone. I noticed that the IEEE  
Hack from Takehiro is disabled in this patch, and if you look at the  
graph in https://tmkk.undo.jp/lame/index_e.html it seems that with  
current CPUs it is not beneficial anymore. Another thing I noticed is  
that an assert is commented out. No idea why.

So if someone could review if what is there is a sane approach (also  
in terms of difference in the FP precission!) we could maybe integrate  
this speed improvement.

There is also a patch for a faster CRC routine:
    https://hydrogenaud.io/index.php?topic=115900.0
Anyone up to have a look at this?

2. libmpg123:
Also in terms of libmpg123 and the API for the analyzer... as nobody  
seems to have stood up into looking into the analyzer part, it doesn't  
seem to be that interesting anymore. So I can imagine two reactions to  
this, either remove the analyzer part (given that it uses gtk1 maybe  
the preferred solution?), or to commit the switch to libmpg123  
(assuming there will be a release of libmpg123 with this API close  
enough to the decission which way to go).

and 3. new release:
No matter what we would decide for point 1 and 2, we should make a new  
release with the bug fixes we have so far. If we can come to the  
conclusion that we want to integrate the patches from 1 and/or 2,  
ideally the release should include that, but having a release "now"  
for the bugfixes wouldn't be bad either (and a second release shortly  
after with some perf improvements would allow to switch back the the  
bugfix release before in case we have overlooked something in the perf  
patches). Robert, would you be up for creating a release "now"?

Comments please.

Bye,
Alexander.

-- 
http://www.Leidinger.net [email protected]: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    [email protected]  : PGP 0x8F31830F9F2772BF