Re: [PATCH] frontend: mark unused WAVE_FORMAT_EXTENSIBLE fields

Alexander Leidinger via Lame-dev <[email protected]> Sat, 18 Jul 2026 13:38:04 +0200

Newsgroups	gmane.comp.audio.mp3.lame
Organization	No organization, this is a private message.
Message-ID	<[email protected]>

Am 2026-07-17 21:18, schrieb Maya R. Odinezenko via Lame-dev:
> Hello,
> 
> A small cosmetic one. In parse_wave_header() (frontend/get_audio.c)
> the three parsed-but-unused WAVE_FORMAT_EXTENSIBLE fields are marked
> with a single
> 
>     (void) (ui16_cbSize, ui16_wValidBitsPerSample, ui32_dwChannelMask);
> 
> but the comma operator evaluates and discards the first two operands,
> so that cast silences only the last one; clang still reports
> -Wunused-value on the other two. The patch marks each field with its
> own (void) cast. No runtime or file-output effect; it just removes the
> two remaining warnings.

I plan to fix that differently (together with some other warnings, 
ignore them for the moment please).

Thanks,
Alexander.

-- 
http://www.Leidinger.net [email protected]: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    [email protected]  : PGP 0x8F31830F9F2772BF