[mb-commits] branch, mbs-3856-revert-barcode-search, updated. MBS-3856: Fix ./admin/RemoveBarcodeCoverArtUrls.pl (fixup 9737724).

The branch, mbs-3856-revert-barcode-search has been updated
       via  http://git.musicbrainz.org/gitweb/?p=musicbrainz-server/core.git;a=commit;h=3337714adb6c287c0b29789b8ebbe499ab15d527 (commit)
      from  http://git.musicbrainz.org/gitweb/?p=musicbrainz-server/core.git;a=commit;h=97377244a61dc3d6136e45bcf4c95ce18b61b5d2 (commit)

Summary of changes:
 lib/MusicBrainz/Script/RemoveBarcodeCoverArt.pm |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3337714adb6c287c0b29789b8ebbe499ab15d527
Author: Johannes Weißl <[email protected]>
Date:   Mon Dec 17 00:02:36 2012 +0100

    MBS-3856: Fix ./admin/RemoveBarcodeCoverArtUrls.pl (fixup 9737724).

diff --git a/lib/MusicBrainz/Script/RemoveBarcodeCoverArt.pm b/lib/MusicBrainz/Script/RemoveBarcodeCoverArt.pm
index 1341658..a38f699 100644
--- a/lib/MusicBrainz/Script/RemoveBarcodeCoverArt.pm
+++ b/lib/MusicBrainz/Script/RemoveBarcodeCoverArt.pm
@@ -25,20 +25,20 @@ sub find_releases
 
     my @url_types = $self->handled_types;
 
+    # Find all releases that have a cover art url and barcode, but no
+    # URL relationship that would explain the cover art url.
     my $query = '
         SELECT DISTINCT ON (release.id)
             release.id AS r_id
         FROM release
-        LEFT JOIN release_coverart ON release.id = release_coverart.id
+        JOIN release_coverart ON release.id = release_coverart.id
         LEFT JOIN l_release_url l ON ( l.entity0 = release.id )
         LEFT JOIN link ON ( link.id = l.link )
         LEFT JOIN link_type ON (
           link_type.id = link.link_type AND
           link_type.name IN (' . placeholders(@url_types) . ')
         )
-        LEFT JOIN url ON ( url.id = l.entity1 )
         WHERE link_type.name IS NULL AND release.barcode IS NOT NULL
-        AND release_coverart.cover_art_url IS NOT NULL
         ORDER BY release.id';
 
     return query_to_list($self->c->sql, sub {

-----------------------------------------------------------------------


hooks/post-receive
-- 
mb_server

_______________________________________________
MusicBrainz-commits mailing list
[email protected]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-commits