Re: [mb-users] Edit Expiration Times (MBS-2614, MBS-4594)
Frederic Da Vitoria <[email protected]>
| Newsgroups | gmane.comp.audio.musicbrainz.user |
|---|---|
| Message-ID | <CANe_y9QRaFjkTGVfWEcBF1CL4gXLEBmi4uWPUg6cTgLOgtP-Pg@mail.gmail.com> |
2012/8/15 Calvin Walton <[email protected]> > On Tue, 2012-08-14 at 21:29 -0500, Brandon LeBlanc wrote: > > Hey Gang! > > > > So, I'm working on MBS-2614 [1] and MBS-4594 [2] and I have a question > > for the users. The gist of the issues is that when edits expire, be it > > by the expiration date or the unanimous rule, they aren't closed and > > applied immediately. Edits remain open for voting until when they are > > closed at the top of the hour by ModBot, provided there are no bugs in > > the server preventing their application. Edits that have expired but > > are still open display "Already expired," which is confusing for some > > who are unfamiliar with how our edit system works. > > > > There are four proposed solutions to these tickets: > > 1) Make edits close and apply as soon as they expire. > > This would be the ideal option, but I'm actually a little curious about > how it'll be implemented (maybe this is more appropriate for the dev > list, but...) > > In order to expire edits, you need some sort of backend process that > notices when the edit expires, and does the required application steps. > This process is currently called "ModBot" and runs once every hour - and > is a fairly heavy job when it does run. Do you plan to have some sort of > reduced-functionality ModBot-like process that runs more often? Even so, > I doubt you could get the delay down below a couple minutes or so. > > I suppose the other idea might be to trick people - if someone views a > resource that has a pending expired edit, you could apply the edit > immediately in the web server process before rendering the page. > > (The other case, making an edit apply immediately upon receiving e.g. a > 3rd unanimous yes vote, would be much easier to handle, this could just > be applied when the 3rd vote is received in the same way as an > autoeditor approval applies immediately.) > I agree that solution1, although preferable, may be too costly to implement. Couldn't solution 4 be improved by displaying the hour at which ModBot should apply the edit? -- Frederic Da Vitoria (davitof) Membre de l'April - « promouvoir et défendre le logiciel libre » - http://www.april.org _______________________________________________ MusicBrainz-users mailing list [email protected] http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-users