Re: Crash: Manage MIDI Devices window, testing appreciated

chuck elliot <[email protected]> Wed, 22 Jan 2025 15:06:29 +0000

Newsgroups	gmane.comp.audio.rosegarden.user
Message-ID	<[email protected]>

I rebuilt from git (rg reports as: Rosegarden version: 25.06 
("Joyfulness") Build key: cf3aa06ee6 (24.12-116-g05e0ed3d2))

and tried a variety of operations with the MDM

(new device, import bank, delete device, close, reopen, redo, undo, new 
project, etc, etc)

and suffered no crashes.

Chuck.



On 20/01/2025 22:48, Ted Felix wrote:
> Just fixed a crash when closing the Manage MIDI Devices dialog 
> reported over at Debian:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091859
>
>   I've pushed the fix to master and it needs review and testing before 
> I do a 24.12.1 release to get this fixed for everyone.
>
>   To test, build the latest from master then open and close the Manage 
> MIDI Devices window (Studio > Manage MIDI Devices).
>
>   For more thorough testing, add and remove some devices.  Then maybe 
> do some undo/redos.  And whatever else you usually do here. Finally, 
> close the window or even just create a new document while it is up.
>
>   Hopefully you will encounter no crashes on close of the Manage MIDI 
> Devices window.  Let me know if you do.
>
>   If anyone wants to review the changes:
>
> https://sourceforge.net/p/rosegarden/git/ci/64943ed3d8282fc9893129e69ed435057f55e759/ 
>
>
>   It appears to have been an erase-while-iterating error.  I was 
> unable to get it to crash, so I'm only guessing.
>
>   I'll give this a week before going through the release process. Any 
> help anyone can provide is appreciated.  Thanks.  And let me know how 
> it goes.
>
> Ted.
>
>
>
> _______________________________________________
> Rosegarden-user mailing list
> [email protected] - use the link below to unsubscribe
> https://lists.sourceforge.net/lists/listinfo/rosegarden-user

_______________________________________________
Rosegarden-user mailing list
Rosegarden-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user

OpenPGP_0x4614F6C2B06D95A4.asc (application/pgp-keys, 2.4 KB)

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsDNBGFtlFYBDAC/tv3brPKP6/aaAyAzRaszpZlbAe35wQaXFThyJWVmQuAWm0xu
oWT3+UH8vyk9t6VxJ8Krh8XvsTYXrBMtWrAojRltxTjCLj2y8GSDXrZdFu1Gr+K6
EZiAa+gUSEvGUFxV6DyiWzBpbmsnQbyuLhRfi8BNIrWRPvovYaRN1XqPxKdFw8S3
wv6k6FvvGArEQIUZq8eXypUSD+3RKytecWA6cJ7xh4lV85ApFh4URDBsHnv0oPsi
mu5RnPY6EkEAwP/eAr67gXjTenmodkt3vKaGZKoPJndma3M03K3UbzFgOFU+ePhy
FsYy/CjSAAFOV81pbt0XY1dvbd3R/G/1LU44OffUb1+qWgPIM/0QiEps50NVpiG+
y4oI9nAFMgzbxca4lANKw5RH4K4rLDeYAf5/R24L/8F2aVoLqWe2nL+Vym1oE7ug
GrVE0tf8LZqqlgqIZXWrCCd24O+Q1bvygsEzppJqtNESKF00H8Q8sOa8eZxneJna
PttFmoHmfzjcQnEAEQEAAc0hY2h1Y2sgZWxsaW90IDxjLmVsbGlvdEBwb2JveC5j
b20+wsEJBBMBCAAzFiEESurK957WzJX02n+JRhT2wrBtlaQFAmFtlFgCGwMFCwkI
BwIGFQgJCgsCBRYCAwEAAAoJEEYU9sKwbZWkvYUL/iZNB/gLyowCY8vqla4M62Is
I3MnlBkf31y0x34CCPH3HieQkyVSboLzd7VPsnvG64kUHNLpB21XjGZ4hCxuftiZ
rvPQOhR9t33xZbYJvbExPYUZ8nHW+aT6tsK7tSc7MFcX/kWtZXp/PUHMtuiP6z7u
u1rzOREELLTNts4HUFt2d/hNmRnQ/SfIVfTWsEvTOKF9SHiIyYJartWEZSc663N9
FEL8zweD5tF4EnHC0wxCb7cAqTSn7874ZLz8ORrjtMGr5z7fgm4jRcMEPNgH5o+m
6tTl+GvU+2Lt0yp0JNMHKRBpZZ7pSRb6JpTnfVwq7bkY+msATfphrfe8TDf0RBIr
W5Qe/UMwRdOb7K9I9FaCUXc2VGrkXW+tekN5kM8GbaOolIFblFFI3daTx35OI+Oq
sYti1aNItvdXrpHC9l+Y9qQ/jw6Y4yoKq5UpVthtn9GUsaispfkc3Q+Su03PxIZp
VD5iMoAWm9oYtaiFw+3LJa4Qtt1AgE4CEB2tXxKjBM7AzQRhbZRZAQwAyYrEykGX
tsIQJrZ2YEuxlhuwZK/7+sJjIYGGS1bv4jhlIagx0TKQYTQ1F8hfqC+F7qSWIHTE
SU+zg4SpKLpvTP84/nKNXT/4kk9Eb+wQw3P8a7ExMrIS6Qr6VXT4l2a5k6jFHrX5
76pPqDfwUYUFZLIwQeX+nsanSkd1ORuQS5EU+VPm9vKTZ1s/i+kbEdKigNWmId5T
Ub99oIUDIrb2a/sQmaLB0Bfdi/vrdtRw+Nxzi812nIxQWdMFAl8J7KnhDdb355Nq
moCsqxZEXAdPZfk9KS65GIl6JX0EirrZKoGSuwaoRfMWyyBbDBj7cWGAkvaor4ek
hEEACfPSBQdLKEpoVLoQd9272uRAYp5+pd6flttK9KTvnS18TOYa2LpzHvZdl7Va
/EbbHGsC+f3aH3Lz4BZmBtnJ4DRT7dMlGEY0RyzpxBkKbeVWieUkDEF9J01nFqaR
7LIAwqAB80osBaZvDng6vPOWqswXNFsNl9n+lJC4a3RzBd2exIm1JQKFABEBAAHC
wPYEGAEIACAWIQRK6sr3ntbMlfTaf4lGFPbCsG2VpAUCYW2UWgIbDAAKCRBGFPbC
sG2VpB3ZC/400B5OHuDVAFuhWjjY/Rdxd8dQimpuBpJzcn4ztdv9fNEPOAW0Lcdi
O9IZCxW+k7z7t0ZCHzJWd/62seTqs80lYPAwkKthOl9kjOwn99gh+eF4+czWePeh
14KLJg7B/ZGGvdnfkln8wWHh0zTajfhg0X/E7CoRD0T8AqhCdZPr5ra1/iQTpw3W
E/WZl3nNx9GLHrTjOBxyfDPsZC6p420iVSGWuaVI3tgaUuBbyThHgdA22K/0ZXqp
jII+pcx5H1sFUsNh/tAsWT1eH6B3BDvdmiGSWfIOduwP1M2triy0MVTRaiOhmBBe
FTfMiX3KyvrMuJ9M4shvd5bi1/l5mtwX4JJEIkWrQ59UvUTMB8wQunSQgapjTNR4
Ks5yqvvczGAiPi9MVWQD+NL4mgAUlbB2Hm0YAtvBHuwEuW9UyiCn71dFsmltEy1o
h/YYtK9GAYGUjMAUisNsA2BzynoXbF0ucxivUOdCrPjlycHJjcg2A7LGh89+71UY
0mkTeRcCmqI=
=VVXi
-----END PGP PUBLIC KEY BLOCK-----

OpenPGP_signature.asc (application/pgp-signature, 665 B)

-----BEGIN PGP SIGNATURE-----

wsD5BAABCAAjFiEESurK957WzJX02n+JRhT2wrBtlaQFAmeRCXYFAwAAAAAACgkQRhT2wrBtlaTc
XQv/Qf7+I4ZzVkKDqg98j5Kpl9DuMBxoM8T+3106wY/H1+r+gbwWj+YbvzAqzAJDlAD76vcC1OXE
0ijBYUmF7suSLvu1qLl/lh5/ZfA2NdQxaMIp4x1TrdpnBzu6/cjXWo46ycSDblkXdDC1g7Zjn+VG
GhNANJh+7BxWFWMOUH1jSbJb646IO5eVDn3KvplRwwJLq7vyXnPLFUaNQQ0VOIJONSZbR5lf4PwO
EuGaZmGZhNKd5gPCejND4IXVICoYWPqPHYISjL+GPYlgKtpoBedEKTr4B2E0cL+e6ERvrlE6eOGF
IBMmL8lk6jI6lRDFfgUwmrnt1bCz5IRpPKonw2s/vtUhz3QW32qvw7FWIhqlq1K1EXekqqLeGhAN
FgUYkuJgH9GWEhBc/p4Bpl+e8ZsR1rMqq6R2FeUwljaMvghxIYk0dTDGuVN58N1vy1peJIbWywFk
PFVgoSnH2/YPRPe3gpizAkkyZEpmgl0W2dSU4VmU1IVk8ZsA98OqlYYj13YC
=NseU
-----END PGP SIGNATURE-----