Re: [supercollider/supercollider] sclang: Ugen: composeBinaryOp add missing ^ (#5000)

W00t, Issue 5000!

Thanks for all the hard work, devs!

Cheers,
eddi

--
https://soundcloud.com/all-n4tural
https://alln4tural.bandcamp.com

On 09/06/2020, 14:43 gianlucaelia <[email protected]> wrote:

Purpose and Motivation

UGen:composeBinaryOp checks if the other operand isValidUGenInput, and if not, calls otherOperand.performBinaryOpOnUgen(this) (pseudo). However, it doesn't return the latter's return value, making it ineffective.

This has been like that since the dawn of time (+18 years?), however, all implementations of performBinaryOpOnUgen seem to expect their value to be returned:

supercollider/SCClassLibrary/Common/Math/Complex.sc

Line 78 in f65a1ef

^aUGen.asComplex.perform(aSelector, this, adverb)

supercollider/SCClassLibrary/Common/Math/Polar.sc

Line 50 in f65a1ef

^Complex.new(

supercollider/SCClassLibrary/Common/Core/Object.sc

Line 683 in 9be3fe2

^this.performBinaryOpOnSomething(aSelector, thing, adverb)

Types of changes

- Bug fix

To-do list

- Code is tested

- [] All tests are passing

- This PR is ready for review

----------

You can view, comment on, or merge this pull request online at:

https://github.com/supercollider/supercollider/pull/5000

Commit Summary

- sclang: Ugen: composeBinaryOp add missing ^

File Changes

- M SCClassLibrary/Common/Audio/UGen.sc (2)

Patch Links:

- https://github.com/supercollider/supercollider/pull/5000.patch

- https://github.com/supercollider/supercollider/pull/5000.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub , or unsubscribe .

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.birmingham.ac.uk/facilities/ea-studios/research/supercollider/mailinglist.aspx
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/