Re: Refactoring Patch 2 and 3 [re-submit]

On Wed, 2003-08-13 at 11:07, Ralf Engels wrote:
> Hi,
> I checked again the patch I send two days ago.
> It was ok.
> Only the second patch (still unsend till now) has a problem. Included is
>    the patch to patch the patch.
> 
> 
> The overall target is to clean up even more. The pmo class should have
> no reference to pmi. The pmi should not care about pmo.
> And what I want is to have multiple pmo classes possible so that you can
> plug in some effects in the pipeline.
> 
> The patch 2 cleans up different things. The patch three solves the
> Prepare issues once and for all.
> The overall line count of these patches is always negative. Zinf gets
> simpler!

I'm disinclined to apply the latest patch as it uses
strncmp, strchr, instead of std::string functionality.

Here's an abbreviated version of std::string 
http://www.msoe.edu/eecs/ce/courseinfo/stl/string.htm

Please don't spend time renaming PullBuffer *& buf ->
PullBuffer **buf.   A more useful patch would be to create
a reference counting, thread safe proxy of PullBuffer so
that the audio pipeline could have forks for other style
plugins such as filewriters or visuals.

input -> LMC -> output
      |      +> Visual
      +> file writer
Notice that both filewriter and Visual need read-only copies
of the buffer, it would be best to able to keep track of how many
elements of the pipeline need a copy and delete the puffer only
when the last element is done.

Check out GstBuffer, and GstBufferPool in

http://www.gstreamer.net/docs/gstreamer/gstreamer.html

> 
> PS: my first mail was rejected because it was to big. Can I send just the attachements for the time being? Is there another way short of CVS access?

Please send attachments.










-- 
email:[email protected] office:(805)893-4276 http://www.cs.ucsb.edu/~kris



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01