Re: Refactoring Patch 2 and 3 [re-submit]
Andreas Rottmann <[email protected]>
| Newsgroups | gmane.comp.audio.zinf.devel |
|---|---|
| Message-ID | <[email protected]> |
"Kristian G. Kvilekval" <[email protected]> writes: > I'm disinclined to apply the latest patch as it uses > strncmp, strchr, instead of std::string functionality. > > Here's an abbreviated version of std::string > http://www.msoe.edu/eecs/ce/courseinfo/stl/string.htm > > Please don't spend time renaming PullBuffer *& buf -> > PullBuffer **buf. A more useful patch would be to create > a reference counting, thread safe proxy of PullBuffer so > that the audio pipeline could have forks for other style > plugins such as filewriters or visuals. > I already once sent source for such a buffer, and it was turned down by Ed Sweetman for being "unnecessarily complex" (i.e. refcounted). I'll look for the source again and re-post it. Regards, Andy -- Andreas Rottmann | Rotty@ICQ | 118634484@ICQ | [email protected] http://www.8ung.at/rotty | GnuPG Key: http://www.8ung.at/rotty/gpg.asc Fingerprint | DFB4 4EB4 78A4 5EEE 6219 F228 F92F CFC5 01FD 5B62 This reality is really just a fucked-up dream -- Papa Roach ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01