Re: music browser

On Sat, 2003-09-13 at 07:17, David Hough wrote:
> On Fri, 12 Sep 2003 19:35:45 -0700, Kristian G. Kvilekval 

> I've had a quick look at the code again and I think the problem is probably 
> due to a call to refresh_item_data() when a row becomes visible. (its in 
> the set_rows_data function of GTKLibraryTree, line 139) I think this is not 
> actually needed, as the subsequent call to item_text should call this 
> anyway if needed, which in a lot of cases it won't be. I haven't got time 
> at the moment to download/install the required libraries for the new code 
> to try this out, but this is the only thing that I can see that could cause 
> the problem.

That got it,  we now have instantaneous opens and fast browsing :)
I've also modified it to get rid of the annoying utf8 messages.

However, we now have a leak .. scroll up and down in any list 
and we loose a lot of memory.   This may be due to the way
children rows are created all the time whether or not they 
have been created before.. any ideas?


A new version is available at my archive.

> Also, as you said you couldn't understand what was going on in the code, 
> would some form of documentation be useful when I get a chance, and if so 
> what would you like to see in it?

I'm unfamiliar with GtkMM and the tree in particular.   An explanation
of the functions in GtkLibraryTree would be most useful.

> I just had a quick look at your gtkmenubar class out of interest, and I see 
> you've got lots of functions that will probably just call the required 
> function in GTKMusicBrowser. If you look at how I did GTKToolbar it might 
> reduce the required code. I just simply made the function in 
> GTKMusicBrowser the signal handler where possible, instead of having a 
> signal handler that only called that function.

Thanks.. I looked at Toolbar, but not closely enough.


-- 
Kristian G. Kvilekval
email:[email protected] office:(805)893-4276 http://www.cs.ucsb.edu/~kris



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf