Re: CD playing broken?

On Mon, 22 Mar 2004 17:27:00 +0000, Robert Hart <[email protected]>  
wrote:

> I think its broken for me. I did start looking into, got as far as
> finding a bug in the albumart plugin, which crops up when playing CDs or
> http streams.
>
> I can see the CD in the music browser, and the tracks, but can't play.
>
> Rob

Yeah, thats basically the problem I've got. I think I've come up with a  
hacked patch that fixes it, for me at least. The only thing is that  
looking at the CVS history, the change to the code that this fixes  
appeared 6 months ago, so should be in the 2.2.5 release as well. Which  
makes me wonder if something odd is going on somewhere else that only  
caused this to become apparent recently, or if its just that no-one ever  
uses zinf to play cds?

Anyway, here's the patch, (at some point I'll branch zinf--fixes and add  
this if it does work for everyone)

--- orig/io/cd/unix/include/cdpmo.h
+++ mod/io/cd/unix/include/cdpmo.h
@@ -59,7 +59,8 @@
     virtual void  Pause(void);
     virtual void  Resume(void);
     virtual Error ChangePosition(int32_t);
-   virtual Error SetTo(const char *url);
+   virtual Error SetUrl(const std::string& track_url);
+

     struct disc_info *GetDiscInfo();
     uint32_t  GetCDDBDiscID();


--- orig/io/cd/unix/src/cdpmo.cpp
+++ mod/io/cd/unix/src/cdpmo.cpp
@@ -106,10 +106,11 @@
      }
  }

-Error CDPMO::SetTo(const char *url)
+Error CDPMO::SetUrl(const std::string& track_url)
  {
     OutputInfo blah;
-
+   const char* url = track_url.c_str();
+
     if (IsError(Init(&blah)))
         return kError_CDInitFailed;

David
-- 
Using M2, Opera's revolutionary e-mail client: http://www.opera.com/m2/


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click