lmc bugginess
Ed Sweetman <[email protected]>
| Newsgroups | gmane.comp.audio.zinf.devel |
|---|---|
| Message-ID | <[email protected]> |
This isn't a malignant bug, but one none-the-less. our lmc's have a method called CalculateSongLength(). This is not used anywhere in zinf and for good reason, it seems to be a holdover from the pre-pmi days. There is no reason why this method should exist and in fact it breaks the pipeline architecture by bypassing our pmi and makes no checks to see if we even have a file that is able to be opened (streaming). This method serves no purpose in zinf now and it should be removed before anyone makes the mistake of using it. Even if it was used it would still have to be removed because it bypasses the pmi thus breaking the pipeline interface. on a side-note, i'm over halfway done completing the new vorbis decoder. It's not using any code from mplayer and instead is roughly based on the example decoder and my own code. Basically what i have left is finish up the decodeWorkerThread function and then test it. I'm making some compromises for speed, since ogg vorbis files dont have anything like xing's vbr tag which gives an exact abr and allows for exact time length without parsing the entire file and somewhat exact seeking (it would be pretty complicated to do exact seeking in a vbr file), i'm using the bitrate_nominal data. the accuracy of this number is soley up to the encoder. I could get the exact data but this would require 1 pass of the entire file which for files up to 6MB/10MB or so is less than a second on my system, but i also have an extremely fast hdd and nothing else is trying to get at it while i'm doing this. The innacuracy shouldn't be too far off so long as the encoder isn't dropping the ball on it. I believe we have the same problems for mp3 files without the xing vbr tag that are vbr as well. ------------------------------------------------------- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en