Re: vorbis decoder stuffs
Ed Sweetman <[email protected]>
| Newsgroups | gmane.comp.audio.zinf.devel |
|---|---|
| Message-ID | <[email protected]> |
Kristian Kvilekval wrote: > > Ed, > I have committed your makefile and lmc changes. > > I don't even feel comfortable trying your patches to the vorbis decoder > at the moment. I am having a hard time believing this is the right > direction to take the vorbis decoder. I, for one, prefer the clarity > of the old decoder. I think more work needs to be done to understand > *why* the current(old) decoder fails on fast track switching. Was it a > race condition in the vorbis lib that you were working around? > Can you pinpoint the code that causes the race? Even if i fixed the old decoder so that it could fast track (which is possible i think), the old decoder depended on access to filehandles. This breaks interface design. It's not acceptable even if it worked completely and this is true of all the decoders. Why have subsystems at all if we're not going to adhere to them. > > > On Mon, 2003-03-31 at 14:59, Ed Sweetman wrote: > >>The problem i'm having with seeking is that with vorbis files when i >>execute the seek command like all the other plugins do with their >>changeposition method the next BeginRead method call always returns >>NoDataAvail. This occurs whenever changePosition method is called even >>when there is no code in the method. That means that either we do >>something different if we have the vorbis lmc loaded in the player code >>(wouldn't put zinf passed a dirty hack like that) or the structure of >>the beginRead's writes, endReads,writes need to be in a certain >>arrangement for shit to work. >> >>Again, fun stuff. At least i know i can remove all the extra >>conditional checks and boolean variables and extra lock. >> >>anyone with any ideas of why changePosition calls cause this problem >>would be appreciated. I'll be working on it some more. >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: ValueWeb: >>Dedicated Hosting for just $79/mo with 500 GB of bandwidth! >>No other company gives more support or power for your dedicated server >>http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/ >>_______________________________________________ >>Zinf-devel mailing list >>[email protected] >>https://lists.sourceforge.net/lists/listinfo/zinf-devel ------------------------------------------------------- This SF.net email is sponsored by: ValueWeb: Dedicated Hosting for just $79/mo with 500 GB of bandwidth! No other company gives more support or power for your dedicated server http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/