Re: Trouble with apbuild dependencies

Jan Niklas Hasse wrote:
> On Wed, Mar 11, 2009 at 1:33 PM, Francesco Montorsi
> <[email protected]> wrote:
>> Jan Niklas Hasse ha scritto:
>>> Should be fixed in r2552: http://trac.autopackage.org/changeset/2552
>>> Thanks for pointing this out.
>> well, since the current GNU libc version is 2.9, shouldn't it warn also if
>> symbols from glibc 2.6, 2.7, 2.8, 2.9 are found? (maybe I'm wrong but it
>> seems to check only for 2.4 and 2.5 now...)
>>
>> Just my 2 cents :)
>> Francesco
> 
> Yeah, that's true. I thought that too when looking at the original
> code. But I was too lazy to fix it properly. I think it's okay though,
> since most binaries compiled with 2.6 or newer also contain at least
> one symbol with 2.4 or 2.5.

Until GLIBC_2.10 is released the following should do the trick:

--- makepackage.2552    2009-03-11 11:28:56.543272000 -0600
+++ makepackage 2009-03-11 11:40:08.562942000 -0600
@@ -1292,10 +1292,7 @@
         stub=$(echo "$stub" | sed "s/%LibCSymbols%/$symbols/")
         found_too_new=false
         for s in $symbols; do
-               if echo "$s" | grep "GLIBC_2\.4" >/dev/null; then
-                       found_too_new=true
-               fi
-               if echo "$s" | grep "GLIBC_2\.5" >/dev/null; then
+               if echo "$s" | grep -E -q "GLIBC_2\.[4-9]"; then
                         found_too_new=true
                 fi
         done


Note that I also replaced the redirection to /dev/null with the use of
the -q (quiet) flag.

-- Scott

---------------------------------------------------------------------
To unsubscribe, e-mail: autopackage-dev-unsubscribe-OfajU3CKLf1/[email protected]
For additional commands, e-mail: autopackage-dev-help-OfajU3CKLf1/[email protected]