Re: [PATCH 2/2] doc: Switch from printenv to env print

Hi Marek,

On 2026-07-18T23:45:48, Marek Vasut <[email protected]> wrote:
> doc: Switch from printenv to env print
>
> The "env" command is the recommended environment management command,
> its "print" subcommand is the equivalent replacement for legacy "printenv"
> command. Update the documentation to use the contemporary "env print"
> command instead of legacy "printenv" command.
>
> Note that the "printenv" command is unlikely to be removed from U-Boot
> in the near future due to it being integral part of the command line
> ABI.
>
> Implemented using:
> $ sed -i 's@\<printenv\>@env print@g' $(git grep -li '\<printenv\>' doc/) README

It looks like you (correctly) skipped doc/usage/cmd/printenv.rst

>
> Signed-off-by: Marek Vasut <[email protected]>
> Reviewed-by: Mattijs Korpershoek <[email protected]>
>
> README                    | 8 ++++----
>  doc/README.odroid         | 4 ++--
>  doc/android/ab.rst        | 2 +-
>  doc/usage/cmd/askenv.rst  | 6 +++---
>  doc/usage/cmd/memsize.rst | 2 +-
>  5 files changed, 11 insertions(+), 11 deletions(-)

> diff --git a/README b/README
> @@ -754,7 +754,7 @@ The following options need to be configured:
> -             env set/printenv to work with. To run a command stored
> +             env set/env print to work with. To run a command stored

This is the one place where the mechanical replacement reads badly.
'setenv/printenv' worked as a shorthand pair, but 'env set/env print'
with the embedded slash is hard to parse.

How about "the env set and env print commands work with" ?

Or "the env set/print commands work with"

In any case:

Reviewed-by: Simon Glass <[email protected]>

Regards,
Simon