Re: [PATCH] arm: socfpga: Reset MPFE NoC after programming peripheral / combined RBF
"Maniyam, Dinesh via U-Boot" <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <[email protected]> |
Hi Tien Fong, On 17/4/2026 4:42 pm, Chee, Tien Fong wrote: > Hi Dinesh, > > > On 25/3/2026 1:46 pm, [email protected] wrote: >> From: Dinesh Maniyam <[email protected]> >> >> This patch triggers warm reset to recover the MPFE NoC from corruption >> due to high frequency transient clock output from HPS EMIF IOPLL at >> VCO startup after peripheral RBF is programmed. >> > > As described in the commit message is not acceptable until the > warm-reset / NoC recovery logic appears in the > > series or the message is narrowed to “add SYSMGR ROM-code offset > definitions for …”. > > >> >> Signed-off-by: Tien Fong Chee <[email protected]> >> Signed-off-by: Dinesh Maniyam <[email protected]> >> --- >> arch/arm/mach-socfpga/include/mach/system_manager_arria10.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h b/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h >> index 0afe63e647e..73e953465a4 100644 >> --- a/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h >> +++ b/arch/arm/mach-socfpga/include/mach/system_manager_arria10.h >> @@ -37,6 +37,10 @@ >> #define SYSMGR_A10_ISW_HANDOFF_BASE 0x230 >> #define SYSMGR_A10_ISW_HANDOFF_7 0x1c >> >> +#define SYSMGR_A10_ROMCODE_CTRL 0x204 >> +#define SYSMGR_A10_ROMCODE_QSPIRESETCOMMAND 0x208 >> +#define SYSMGR_A10_ISW_HANDOFF 0x230 > > > Redundant offset / naming: SYSMGR_A10_ISW_HANDOFF is 0x230, the same > value as SYSMGR_A10_ISW_HANDOFF_BASE > >> + >> #define SYSMGR_SDMMC SYSMGR_A10_SDMMC >> >> #define SYSMGR_SDMMC_SMPLSEL_SHIFT 4 Confirmed against current master -- SYSMGR_A10_ROMCODE_CTRL and SYSMGR_A10_ROMCODE_QSPIRESETCOMMAND already exist, and the warm-reset / MPFE-NoC-recovery sequence this was meant to add is already implemented in spl_a10.c (the "MPFE hang workaround" block, gated on is_fpgamgr_early_user_mode() || is_fpgamgr_user_mode(), which already covers both peripheral and combined RBF). Withdrawing this one -- nothing left to add. We can drop the patch! Regards, Dinesh