Re: [PATCH v3 4/4] configs: Add defconfig for ipq9650 RDP488

Hi Casey,

On 7/16/2026 4:50 PM, Casey Connolly wrote:
> Hi Badhrinath,
>
> On 7/16/26 07:23, Badhrinath S wrote:
>> From: Badhrinath S <[email protected]>
>>
>> Add default configuration for the IPQ9650 RDP488 board with eMMC boot
>> support.
>>
>> Signed-off-by: Badhrinath S <[email protected]>
>> ---
>>   configs/qcom_ipq9650_mmc_defconfig | 21 +++++++++++++++++
>>   configs/qcom_ipqdefconfig          | 37 ++++++++++++++++++++++++++++++
>>   2 files changed, 58 insertions(+)
>>   create mode 100644 configs/qcom_ipq9650_mmc_defconfig
>>   create mode 100644 configs/qcom_ipqdefconfig
>>
>> diff --git a/configs/qcom_ipq9650_mmc_defconfig 
>> b/configs/qcom_ipq9650_mmc_defconfig
>> new file mode 100644
>> index 000000000000..de730067359c
>> --- /dev/null
>> +++ b/configs/qcom_ipq9650_mmc_defconfig
>> @@ -0,0 +1,21 @@
>> +#include "qcom_ipqdefconfig"
>> +CONFIG_SYS_INIT_SP_BSS_OFFSET=0x180000
>> +CONFIG_TEXT_BASE=0x8a280000
>> +CONFIG_NR_DRAM_BANKS=24
>> +CONFIG_ENV_SIZE=0x40000
>> +CONFIG_ENV_OFFSET=0
>> +CONFIG_DEFAULT_DEVICE_TREE="qcom/ipq9650-rdp488"
>> +CONFIG_SYS_LOAD_ADDR=0x90000000
>> +CONFIG_DEBUG_UART_BASE=0x1a98000
>> +CONFIG_DEBUG_UART_CLOCK=14745600
>> +CONFIG_SYS_PBSIZE=1024
>> +CONFIG_CLK_QCOM_IPQ9650=y
>> +CONFIG_CMD_MMC=y
>> +CONFIG_ENV_IS_IN_MMC=y
>> +CONFIG_MMC_SDHCI=y
>> +CONFIG_MMC_SDHCI_ADMA=y
>> +CONFIG_MMC_SDHCI_MSM=y
>> +CONFIG_PINCTRL_QCOM_IPQ9650=y
>> +CONFIG_DEBUG_UART_MSM_GENI=y
>
> Do we really need debug uart in here?
it's not strictly necessary. I've removed the DEBUG_UART configs in v5 
'[PATCH v5 0/4] Add U-Boot support for Qualcomm IPQ9650 SoC' - MARC 
<https://marc.info/?l=u-boot&m=178530478539468&w=2>
>
>> +CONFIG_DEBUG_UART_ANNOUNCE=y
>> +CONFIG_SYS_MALLOC_LEN=0xC0000
>> diff --git a/configs/qcom_ipqdefconfig b/configs/qcom_ipqdefconfig
>> new file mode 100644
>> index 000000000000..6a7f3c1b4ac6
>> --- /dev/null
>> +++ b/configs/qcom_ipqdefconfig
>
>
> Does this defconfig build a functional image? Or is it only ever meant 
> to be included by board specific defconfigs? If it's the latter case 
> then this should be a config fragment instead (just rename the file to 
> qcom-ipq.config or something).
it's only meant for inclusion by board-specific defconfigs, not as a 
standalone build. I've renamed it to qcom_ipq.config in v5 '[PATCH v5 
0/4] Add U-Boot support for Qualcomm IPQ9650 SoC' - MARC 
<https://marc.info/?l=u-boot&m=178530478539468&w=2>
>
>> @@ -0,0 +1,37 @@
>> +CONFIG_ARM=y
>> +CONFIG_SKIP_LOWLEVEL_INIT=y
>> +CONFIG_POSITION_INDEPENDENT=y
>> +CONFIG_ARCH_SNAPDRAGON=y
>> +CONFIG_DEBUG_UART=y
>> +CONFIG_REMAKE_ELF=y
>> +# CONFIG_EFI_LOADER is not set
>> +CONFIG_FIT=y
>> +CONFIG_FIT_VERBOSE=y
>> +# CONFIG_BOOTSTD is not set
>> +CONFIG_OF_BOARD_SETUP=y
>> +CONFIG_USE_PREBOOT=y
>> +# CONFIG_DISPLAY_CPUINFO is not set
>> +CONFIG_DISPLAY_BOARDINFO_LATE=y
>> +CONFIG_HUSH_PARSER=y
>> +CONFIG_CMD_PART=y
>> +CONFIG_OF_LIVE=y
>> +CONFIG_CLK=y
>> +CONFIG_MSM_GPIO=y
>> +# CONFIG_I2C is not set
>> +# CONFIG_INPUT is not set
>> +CONFIG_MISC=y
>> +CONFIG_QCOM_GENI=y
>> +CONFIG_MTD=y
>> +CONFIG_DM_MDIO=y
>> +CONFIG_DM_ETH_PHY=y
>> +CONFIG_DWC_ETH_QOS=y
>> +CONFIG_DWC_ETH_QOS_QCOM=y
>> +CONFIG_RGMII=y
>> +CONFIG_PHY=y
>> +CONFIG_PHY_QCOM_QMP_UFS=y
>> +CONFIG_PHY_QCOM_QUSB2=y
>> +CONFIG_PINCTRL=y
>> +CONFIG_PINCONF=y
>> +CONFIG_MSM_SERIAL=y
>> +CONFIG_MSM_GENI_SERIAL=y
>> +CONFIG_SOC_QCOM=y
>