Re: [PATCH v5 63/75] usb: udc: re-import udc-core.c from kernel v6.16

Hi Anders,

Thank you for the patch.

On Thu, Jul 16, 2026 at 15:42, Anders Roxell <[email protected]> wrote:

> From: Jerome Forissier <[email protected]>
>
> Delete drivers/usb/gadget/udc/udc-core.c which was imported from kernel
> v3.19-rc1 and replace it with drivers/usb/gadget/udc/core.c from kernel
> v6.16. Keep the name udc-core.c for now.
>
> Signed-off-by: Jerome Forissier <[email protected]>
> Signed-off-by: Jens Wiklander <[email protected]>
> Signed-off-by: Anders Roxell <[email protected]>
> ---
>  drivers/usb/gadget/udc/udc-core.c | 1889 ++++++++++++++++++++++++++---
>  1 file changed, 1715 insertions(+), 174 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
> index 6bb419ae2abc..d709e24c1fd4 100644
> --- a/drivers/usb/gadget/udc/udc-core.c
> +++ b/drivers/usb/gadget/udc/udc-core.c
> @@ -1,35 +1,51 @@
>  // SPDX-License-Identifier: GPL-2.0
> -/**
> - * udc-core.c - Core UDC Framework
> - *
> - * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com
> +/*
> + * udc.c - Core UDC Framework
>   *
> + * Copyright (C) 2010 Texas Instruments
>   * Author: Felipe Balbi <[email protected]>
> - *
> - * Taken from Linux Kernel v3.19-rc1 (drivers/usb/gadget/udc-core.c) and ported
> - * to uboot.
> - *
> - * commit 02e8c96627 : usb: gadget: udc: core: prepend udc_attach_driver with
> - *		       usb_


I've file-compared with the mentioned Linux kernel release, and this
looks good to me.

However, in the previous patch (usb: host: re-import xhci-ext-caps.h
from kernel v6.16) you added a small comment to the file stating:

/* Imported from Linux v6.16 */

Can we please be consistent and do that here as well?

With that done:

Reviewed-by: Mattijs Korpershoek <[email protected]>