Re: [PATCH v3] fdt: Fix phandles not copying when using templates

Quentin Schulz <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <[email protected]>
Hi Anshul,

On 7/29/26 12:24 PM, Anshul Dalal wrote:
> The phandles used inside a template are not copied to the node inserting
> the template, leading to a missing phandle error.
> 
> The following example can be used to reproduce the issue:
> 
> &binman {
>    some_template: template-0 {
>      ti-secure-rom {
>        content = <&some_data>;
>        keyfile = "some_key";
>      };
>      some_data: blob-ext {
>        optional;
>      };
>    };
>    output-bin {
>      insert-template = <&some_template>;
>    };
> };
> 

What happens if you insert the template *twice*.

e.g. have:

  &binman {
     some_template: template-0 {
       ti-secure-rom {
         content = <&some_data>;
         keyfile = "some_key";
       };
       some_data: blob-ext {
         optional;
       };
     };
     output-bin {
       insert-template = <&some_template>;
     };
     output-bin2 {
       insert-template = <&some_template>;
     };
  };

? Gut feeling is that this will fail to build because we now have the 
same label for two different nodes.

Cheers,
Quentin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.