Re: [PATCH v2 07/11] rockchip: doc: add more EMMC program examples

Hi Johan,

On 2026-07-28T06:51:38, Johan Jonker <[email protected]> wrote:
> rockchip: doc: add more EMMC program examples

>
> There are more tools that can program a EMMC.
> Add more EMMC program examples.

'a EMMC' should be 'an eMMC', and the rest of the doc uses eMMC rather
than EMMC - please match that in the subject and body.

>
> There are more tools that can program a EMMC.
> Add more EMMC program examples.
>
> Signed-off-by: Johan Jonker <[email protected]>
>
> doc/board/rockchip/rockchip.rst | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> @@ -413,13 +413,22 @@ Upon a successful gadget connection the host shows the USB device with:
> +Program example with rkdeveloptool:
> +
> +.. code-block:: bash
> +
> +        rkdeveloptool db rk3308_loader_v1.26.117.bin
> +        rkdeveloptool wl 0x40 idbloader.img
> +        rkdeveloptool wl 0x4000 u-boot.itb
> +        rkdeveloptool rd

Two things. First, this block sits under the fastboot flow ('Launch
fastboot on the target', device running U-Boot), but rkdeveloptool
doesn't use fastboot - 'db' downloads a loader while the SoC is in
MaskROM mode. Please make clear these are two independent flows
(rkdeveloptool operates from MaskROM, not the running U-Boot).

Second, the surrounding text is RK3399-specific (the lsusb line shows
'RK3399 in Mask ROM mode'), but the loader here is
rk3308_loader_v1.26.117.bin for a different SoC. That loader is a
per-SoC downstream blob, so a reader will need the matching one. A
short note to that effect, or a name consistent with the RK3399
example, would avoid confusion. What do you think?

Regards,
Simon