Re: [PATCH 02/13] video: mediatek: add mixer component
David Lechner <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <[email protected]> |
On 7/28/26 7:29 AM, Julien Stephan wrote:
> The (ETHDR) mixer is one of the components of the video pipeline on
> some MediaTek SoCs, such as the MT8188. Only the mixer sub-block of
> the ethdr is used, which is its first register window.
>
...
> +U_BOOT_DRIVER(mtk_disp_mixer) = {
If this is specific to mt8188, then the identifier should be
mtk_disp_mixer_mt8188. This way, it won't conflict with future
drivers. U-Boot wants all driver names unique for compile
testing as much as possible in the same config.
Same applies to other patches in this series.
> + .name = "mtk_disp_mixer",
> + .id = UCLASS_MISC,
> + .of_match = mtk_disp_mixer_ids,
> + .probe = mtk_disp_comp_probe,
> + .priv_auto = sizeof(struct mtk_disp_comp_priv),
> +};