Re: [PATCH v3 02/12] rockchip: doc: change TPL phrase

Hi Johan,

On 7/30/26 3:33 PM, Johan Jonker wrote:
> The TPL phrase in rockchip.rst has some spelling and logical
> problems. Rewrite and add missing structure by changing to a
> list view to better separate the 2 choices the user has to make.
> 
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> 
> Changed V3:
> add commas
> ---
>   doc/board/rockchip/rockchip.rst | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> index 9351a5b8eae7..5144cbccef78 100644
> --- a/doc/board/rockchip/rockchip.rst
> +++ b/doc/board/rockchip/rockchip.rst
> @@ -219,9 +219,11 @@ For SoCs whose TF-A code is not available as open source, use BL31 binary provid
>   TPL
>   ^^^
> 
> -For some SoCs U-Boot sources lack of support to inizialize DRAM.
> -In these cases, to get a fully functional image following :ref:`PackageWithTPLandSPL`, use DDR binary provided by Rockchip rkbin repository as ROCKCHIP_TPL when building U-Boot.
> -Otherwise, follow :ref:`PackageWithRockchipMiniloader`.
> +* For SoCs with U-Boot sources to initialize DRAM, follow
> +  :ref:`PackageWithTPLandSPL`.

If I remember correctly, it is possible to have an open-source DRAM init 
in U-Boot and still decide to go for the blob.

I think the point here is rather, if CONFIG_ROCKCHIP_EXTERNAL_TPL is 
set, set ROCKCHIP_TPL environment variable to the appropriate *ddr*.bin 
file you can find in rkbin git repository, which will be the TPL stage.

If not, then TPL will be U-Boot.

> +* For SoCs without U-Boot sources to initialize DRAM use the DDR binary provided
> +  by the Rockchip rkbin repository as ROCKCHIP_TPL when building U-Boot, then follow
> +  :ref:`PackageWithRockchipMiniloader`.
> 

This is... completely unrelated? miniloader seems to be appended after 
the DDR bin blob (see create idbloader.img step), so it simply isn't 
that. I'm wondering if this isn't some U-Boot proper from Rockchip? I 
have never used the miniloader knowingly so I don't know what it's 
supposed to do unfortunately.

In any case, I think the appropriate replacement is simply to mention 
CONFIG_ROCKCHIP_EXTERNAL_TPL and ROCKCHIP_TPL.

Cheers,
Quentin