RE: [PATCH v2] power: regulator: tps65219: Fix LDO selector boundaries

> From: U-Boot <[email protected]> On Behalf Of Kumara Bhimeswararao Matsa
> 
> According to the TPS65219 datasheet, selectors 0x38 through 0x3f
> map to 3.4 V for LDO1 and LDO2.
> 
> For LDO3 and LDO4, selectors 0x00 through 0x0c map to 1.2 V,
> while selectors 0x36 through 0x3f map to 3.3 V.
> 
> The driver currently uses 0x56, 0x12, and 0x54 as selector boundary
> values. These values do not match the selector boundaries defined by
> the datasheet.
> 
> Use the correct selector boundary values of 0x38, 0x0c, and 0x36.
> 
>  #define TPS65219_LDO12_VOLT_MIN		 600000
>  #define TPS65219_LDO12_VOLT_MAX		3400000
>  #define TPS65219_LDO12_VOLT_REG_MIN	0
> -#define TPS65219_LDO12_VOLT_REG_MAX	0x56
> +#define TPS65219_LDO12_VOLT_REG_MAX	0x38

If the maximum for 3.4V is 0x3f then why do you use 0x38 here?

>  #define TPS65219_LDO34_VOLT_MIN		1200000
>  #define TPS65219_LDO34_VOLT_MAX		3300000
> -#define TPS65219_LDO34_VOLT_REG_MIN	0x12
> -#define TPS65219_LDO34_VOLT_REG_MAX	0x54
> +#define TPS65219_LDO34_VOLT_REG_MIN	0x0c

If the minimum for 1.2V is 0x00 then why do you use 0x0c here?

> +#define TPS65219_LDO34_VOLT_REG_MAX	0x36

If the maximum for 3.3V is 0x3f then why do you use 0x36 here?

Kind regards,
Maarten Brock