Re: [PATCH] configs: socfpga_common: Add fatscript env for optional U-Boot script

Hi Dinesh,

On Thu, 07 May 2026 08:53:58 +0800, [email protected] wrote:

> Add 'scriptfile' and 'fatscript' environment variables to the SoCFPGA
> common config so that users can drop an optional U-Boot script
> (u-boot.scr) on MMC partition 0:1 and execute it without modifying
> the source code. This is useful for board-specific customisation such
> as register tweaks at boot time. The script is optional and not
> required for normal booting; users can invoke it manually with
> "run fatscript" or include it in their bootcmd as desired.

Commit message understates default-boot activation of fatscript.

The commit body says the script is optional/not required for normal 
booting and that users can invoke it manually with "run fatscript" or 
include it in bootcmd as desired. On upstream master tip parent, 
socfpga_cyclone5_defconfig, socfpga_ac501soc_defconfig, and 
socfpga_ac550soc_defconfig already set CONFIG_BOOTCOMMAND="run 
fatscript;bridge enable; run distro_bootcmd" while parent 
socfpga_common.h has no scriptfile/fatscript. Those boards include 
configs/socfpga_common.h. This patch therefore supplies the missing env 
for an already-wired default boot path (graceful no-op if u-boot.scr is 
absent via the if fatload ... then source ... fi form), not merely an 
optional manual helper. Respin the commit message to state that it 
completes existing BOOTCOMMAND consumers and describe the no-file no-op 
behavior.

Please: Rewrite commit message: mention cyclone5/ac501/ac550 BOOTCOMMAND 
already runs fatscript; env is required for those defaults; missing file 
remains a no-op.


Please send a v2 with the commit message updated as above.

Best regards,
Tien Fong