Re: [PATCH 1/2] cyclic: get rid of cyclic_get_list() helper
Stefan Roese via U-Boot <[email protected]> Mon, 3 Aug 2026 18:25:56 +0200
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <[email protected]> |
On 7/30/26 12:55, Rasmus Villemoes wrote: > As the comment indicates, this was used to silence a warning without > having to add casts everywhere gd->cyclic_list was referenced. But > nowadays gd is not volatile qualified, so this helper is not needed > and only obfuscates the code somewhat, because the head of the list > being operated on with the hlist_ or list_ macros is usually not > obtained via a function call. > > Remove the helper and refer to the list head using the idiomatic > &gd->cyclic_list. > > Signed-off-by: Rasmus Villemoes <[email protected]> Applied to u-boot-watchdog/main Thanks, Stefan