Re: [PATCH 5/6] test: py: gpt: Bind the disk image in test_gpt_write_part_type()
Simon Glass <[email protected]> Tue, 4 Aug 2026 07:05:49 -0600
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <CAFLszThUoePoxiM4XtGrOyMBhvAFvknRcR4y0=oq_vhDuP_+wQ@mail.gmail.com> |
On 2026-07-31T12:39:59, Alexey Charkov <[email protected]> wrote: > test: py: gpt: Bind the disk image in test_gpt_write_part_type() > > Unlike every other test in this file, test_gpt_write_part_type() never > binds the disk image it operates on. It has worked since it was added > only because some test that ran before it left host 0 bound to the > image this fixture provides. > > That breaks as soon as a test which binds something else is added > above it, and it means the test silently depends on collection order > rather than on its own fixture. Bind the image like the other tests do. > > Fixes: 7a598e633a53 ("test/py: tests: gpt: add test_gpt_write_part_type") > Signed-off-by: Alexey Charkov <[email protected]> > Reviewed-by: Ilias Apalodimas <[email protected]> > > test/py/tests/test_gpt.py | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass <[email protected]>