Re: [PATCH 1/9] ram: rockchip: rk3568: Simplify get_info() ops

Hi Stefan,

On 8/4/2026 5:38 PM, Stefan Monnier wrote:
>> +#define PMUGRF_BASE			0xfdc20000
> 
> Could we get some comment here (or in the file header) hinting at where
> the magic number comes from?

I do not think that is necessary, we have defined base addresses all
over Rockchip platform without any such comment.

The base addresses are clearly stated in both SoC TRM and the SoC DT.

  RK3568 TRM - Table 1-1 Address Mapping
  module	start address	size
  PMU_GRF	0xFDC20000	64KB

and

  pmugrf: syscon@fdc20000 {
  	compatible = "rockchip,rk3568-pmugrf", "syscon", "simple-mfd";
	reg = <0x0 0xfdc20000 0x0 0x10000>;
  };

Regards,
Jonas

> 
> 
> === Stefan
>