Re: [PATCH v4 2/9] rockchip: doc: add mask ROM mode text

Hi Johan,

On 2026-08-03T19:09:22, Johan Jonker <[email protected]> wrote:
> rockchip: doc: add mask ROM mode text
>
> Add text that explains how to get into mask ROM mode.
>
> Signed-off-by: Johan Jonker <[email protected]>
>
> doc/board/rockchip/rockchip.rst | 26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)

> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> @@ -321,6 +321,28 @@ To build rk3588 boards:
> +Mask ROM mode
> +-------------
> +
> +The mode that the boot ROM falls back into that listens to
> +0x471/0x472 USB commands.

Sentence fragment - no main verb. Perhaps 'Mask ROM mode is the
fallback mode of the boot ROM, in which it listens for USB commands
0x471/0x472.'

> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> @@ -321,6 +321,28 @@ To build rk3588 boards:
> +Options to get your board into Mask ROM mode:
> +
> +* Holding the recovery button, depending on firmware support or wiring,
> +  when booting the board.
> +* Remove any SD cards, removable eMMC or removable UFS modules.
> +* Erase any storage media containing boot firmware.

Please make these consistent - the first is a gerund fragment, the
rest are imperatives. E.g. 'Hold the recovery button ... while booting
the board'.

> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> @@ -321,6 +321,28 @@ To build rk3588 boards:
> +Methods of last resort (USE AT YOUR OWN RISK):
> +
> +Pins that should be connected/sorted for a
> +short period when the board is connected to power, so that boot ROM
> +cannot locate any boot firmware and falls back into Mask ROM mode.

'sorted' should be 'shorted', and this is a fragment. Perhaps 'Short
the following pins briefly while powering the board, so the boot ROM
cannot locate any boot firmware and falls back into Mask ROM mode:'
leading into the bullets.

With those:

Reviewed-by: Simon Glass <[email protected]>

Regards,
Simon