Re: [PATCH v2 3/5] clk: rockchip: pll: fix RK3588 frac PLL result for k=-32768

Hi Alexey,

On 7/23/26 5:04 PM, Alexey Charkov wrote:
> Current code needlessly sets the k value to 0 when it is calculated as
> -32768, which is a valid value for the RK3588 frac PLL. This results in
> the PLL output frequency being higher than requested when the requested
> frequency is exactly halfway between two integer-multiplier PLL output
> frequencies.
> 
> Negative values of k cannot be greater than 32768 in magnitude either,
> because that case has been handled just above the enclosing if statement,
> so the check for k > 32767 is redundant.
> 
> Fixes: 6bfb37e70209 ("clk: rockchip: rk3588: fix up the frac pll calculation")

Reviewed-by: Quentin Schulz <[email protected]>

Thanks!
Quentin