Re: [PATCH 1/4] pinctrl: mediatek: select PINCONF
David Lechner <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <e7e67d6e-2b8c-4ba9-ad2b-f5811a8b5453__36532.4593543605$1786107479$gmane$org@baylibre.com> |
On 8/7/26 7:15 AM, Julien Stephan wrote: > Le lun. 3 août 2026 à 22:57, David Lechner <[email protected]> a écrit : >> >> All MediaTek targets include pinconf registers so we should just always >> select PINCONF instead of requiring each config to explicitly enable it. >> > > This is not true for MT8518 (see diff on patch 4 that removes only > CONFIG_PINCTRL_MT8518). > So after this series, MT8518 will enable PINCONF by default. Is it > intentional? Did you test it? > Maybe select PINCONF if !TARGET_MT8518 ? I don't have hardware to test but I did compile it. The driver actually has push/pull and drive registers defined, so it makes sense to enable it on this target. I think best would just to mention it in the commit message. > >> Signed-off-by: David Lechner <[email protected]> >> --- >> drivers/pinctrl/mediatek/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig >> index 5a90d74a9e1..42c7c8b8c80 100644 >> --- a/drivers/pinctrl/mediatek/Kconfig >> +++ b/drivers/pinctrl/mediatek/Kconfig >> @@ -2,6 +2,7 @@ if ARCH_MEDIATEK >> >> config PINCTRL_MTK >> depends on PINCTRL_GENERIC >> + select PINCONF >> select REGMAP >> select SYSCON >> bool >> >> -- >> 2.43.0 >>