Re: [PATCH 03/15] clk: rockchip: pll: Always write the k param

Quentin Schulz <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <ea45a145-5620-4796-b297-01315fd78bb9__34006.9714513206$1786109384$gmane$org@cherry.de>
Hi Jonas,

On 7/30/26 4:12 PM, Jonas Karlman wrote:
> The k param help determine when a rk3588_pll fracpll should enable or
> bypass use of fractal mode.
> 
> Change to always write the value of the k param to reg to allow fractal
> re-configuration and closer match how Linux behaves.
> 

There's just one worry that we're writing to undocumented registers when 
this is called on an integer PLL for which PLLCON2 is not defined in the 
TRM (from the discussion we had with Alexey some weeks ago). However, 
the kernel does this already so I guess it's fine.

Fixes: b851c006a150 ("clk: rockchip: pll: Add pll_rk3588 type for rk3588")
Reviewed-by: Quentin Schulz <[email protected]>

Thanks!
Quentin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.