Re: [PATCH 5/7] arm: dts: add mt6366 PMIC include

On Wed, Aug 5, 2026 at 6:33 AM David Lechner <[email protected]> wrote:
>
> Add a mt6366.dtsi file for the MediaTek MT6366 PMIC. For now, this just
> includes the regulators since that is all that U-Boot uses. This should
> eventually be replaced by an upstream devicetree file.
>
> Signed-off-by: David Lechner <[email protected]>
> ---
>  arch/arm/dts/mt6366.dtsi | 273 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 273 insertions(+)
>
> diff --git a/arch/arm/dts/mt6366.dtsi b/arch/arm/dts/mt6366.dtsi
> new file mode 100644
> index 00000000000..9b3a23d51b6
> --- /dev/null
> +++ b/arch/arm/dts/mt6366.dtsi
> @@ -0,0 +1,273 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> +/*
> + * Copyright (c) 2026 MediaTek Inc.
> + */
> +
> +&pwrap {
> +       pmic: pmic {
> +               compatible = "mediatek,mt6366", "mediatek,mt6358";
> +
> +               regulators {
> +                       compatible = "mediatek,mt6366-regulator", "mediatek,mt6358-regulator";
> +
> +                       mt6366_vdram1_reg: vdram1 {
> +                               regulator-name = "vdram1";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <2087500>;

Please don't add default full-range voltages and default names. They
make no sense. Both can be derived from the node and the PMIC's compatible
string.


ChenYu

> +                               regulator-enable-ramp-delay = <0>;
> +                       };
> +
> +                       mt6366_vcore_reg: vcore {
> +                               regulator-name = "vcore";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <200>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vpa_reg: vpa {
> +                               regulator-name = "vpa";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <3650000>;
> +                               regulator-enable-ramp-delay = <250>;
> +                       };
> +
> +                       mt6366_vproc11_reg: vproc11 {
> +                               regulator-name = "vproc11";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <200>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vproc12_reg: vproc12 {
> +                               regulator-name = "vproc12";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <200>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vgpu_reg: vgpu {
> +                               regulator-name = "vgpu";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <200>;
> +                       };
> +
> +                       mt6366_vs2_reg: vs2 {
> +                               regulator-name = "vs2";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <2087500>;
> +                               regulator-enable-ramp-delay = <0>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vmodem_reg: vmodem {
> +                               regulator-name = "vmodem";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <900>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vs1_reg: vs1 {
> +                               regulator-name = "vs1";
> +                               regulator-min-microvolt = <1000000>;
> +                               regulator-max-microvolt = <2587500>;
> +                               regulator-enable-ramp-delay = <0>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vdram2_reg: vdram2 {
> +                               regulator-name = "vdram2";
> +                               regulator-min-microvolt = <600000>;
> +                               regulator-max-microvolt = <1800000>;
> +                               regulator-enable-ramp-delay = <3300>;
> +                       };
> +
> +                       mt6366_vsim1_reg: vsim1 {
> +                               regulator-name = "vsim1";
> +                               regulator-min-microvolt = <1700000>;
> +                               regulator-max-microvolt = <3100000>;
> +                               regulator-enable-ramp-delay = <540>;
> +                       };
> +
> +                       mt6366_vibr_reg: vibr {
> +                               regulator-name = "vibr";
> +                               regulator-min-microvolt = <1200000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-enable-ramp-delay = <60>;
> +                       };
> +
> +                       mt6366_vrf12_reg: vrf12 {
> +                               regulator-name = "vrf12";
> +                               regulator-min-microvolt = <1200000>;
> +                               regulator-max-microvolt = <1200000>;
> +                               regulator-enable-ramp-delay = <120>;
> +                       };
> +
> +                       mt6366_vio18_reg: vio18 {
> +                               regulator-name = "vio18";
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
> +                               regulator-enable-ramp-delay = <2700>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vusb_reg: vusb {
> +                               regulator-name = "vusb";
> +                               regulator-min-microvolt = <3000000>;
> +                               regulator-max-microvolt = <3100000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vcn18_reg: vcn18 {
> +                               regulator-name = "vcn18";
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vfe28_reg: vfe28 {
> +                               regulator-name = "vfe28";
> +                               regulator-min-microvolt = <2800000>;
> +                               regulator-max-microvolt = <2800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vsram_proc11_reg: vsram-proc11 {
> +                               regulator-name = "vsram_proc11";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <240>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vcn28_reg: vcn28 {
> +                               regulator-name = "vcn28";
> +                               regulator-min-microvolt = <2800000>;
> +                               regulator-max-microvolt = <2800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vsram_others_reg: vsram-others {
> +                               regulator-name = "vsram_others";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <240>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vsram_gpu_reg: vsram-gpu {
> +                               regulator-name = "vsram_gpu";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <240>;
> +                       };
> +
> +                       mt6366_vxo22_reg: vxo22 {
> +                               regulator-name = "vxo22";
> +                               regulator-min-microvolt = <2200000>;
> +                               regulator-max-microvolt = <2200000>;
> +                               regulator-enable-ramp-delay = <120>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vefuse_reg: vefuse {
> +                               regulator-name = "vefuse";
> +                               regulator-min-microvolt = <1700000>;
> +                               regulator-max-microvolt = <1900000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vaux18_reg: vaux18 {
> +                               regulator-name = "vaux18";
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vmch_reg: vmch {
> +                               regulator-name = "vmch";
> +                               regulator-min-microvolt = <2900000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-enable-ramp-delay = <60>;
> +                       };
> +
> +                       mt6366_vbif28_reg: vbif28 {
> +                               regulator-name = "vbif28";
> +                               regulator-min-microvolt = <2800000>;
> +                               regulator-max-microvolt = <2800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vsram_proc12_reg: vsram-proc12 {
> +                               regulator-name = "vsram_proc12";
> +                               regulator-min-microvolt = <500000>;
> +                               regulator-max-microvolt = <1293750>;
> +                               regulator-enable-ramp-delay = <240>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vemc_reg: vemc {
> +                               regulator-name = "vemc";
> +                               regulator-min-microvolt = <2900000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-enable-ramp-delay = <60>;
> +                       };
> +
> +                       mt6366_vio28_reg: vio28 {
> +                               regulator-name = "vio28";
> +                               regulator-min-microvolt = <2800000>;
> +                               regulator-max-microvolt = <2800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_va12_reg: va12 {
> +                               regulator-name = "va12";
> +                               regulator-min-microvolt = <1200000>;
> +                               regulator-max-microvolt = <1200000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vrf18_reg: vrf18 {
> +                               regulator-name = "vrf18";
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
> +                               regulator-enable-ramp-delay = <120>;
> +                       };
> +
> +                       mt6366_vcn33_bt_reg: vcn33 {
> +                               regulator-name = "vcn33";
> +                               regulator-min-microvolt = <3300000>;
> +                               regulator-max-microvolt = <3500000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                       };
> +
> +                       mt6366_vmc_reg: vmc {
> +                               regulator-name = "vmc";
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <3300000>;
> +                               regulator-enable-ramp-delay = <60>;
> +                       };
> +
> +                       mt6366_vaud28_reg: vaud28 {
> +                               regulator-name = "vaud28";
> +                               regulator-min-microvolt = <2800000>;
> +                               regulator-max-microvolt = <2800000>;
> +                               regulator-enable-ramp-delay = <270>;
> +                               regulator-always-on;
> +                       };
> +
> +                       mt6366_vsim2_reg: vsim2 {
> +                               regulator-name = "vsim2";
> +                               regulator-min-microvolt = <1700000>;
> +                               regulator-max-microvolt = <3100000>;
> +                               regulator-enable-ramp-delay = <540>;
> +                       };
> +               };
> +       };
> +};
>
> --
> 2.43.0
>