Re: [PATCH v2 0/5] clk: rockchip: pll: fixes and simplification of maths in RK3588 frac PLL
Quentin Schulz via U-Boot <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <178664015269.342950.1712367507580834416.b4-ty__5507.68706468574$1786640179$gmane$org@b4> |
On Thu, 23 Jul 2026 19:04:22 +0400, Alexey Charkov wrote:
> Current fractional PLL code for RK3588 (also applies to RK3576) has two
> issues causing it to overshoot the requested frequency for some negative
> values of the fractional coefficient: one due to rounding, the other due
> to treating -32768 as an invalid value where it is actually valid. It
> also overflows the calculation of the fractional PLL rate when reading
> it back, causing the function to return wrong PLL frequencies for non-
> trivial values of the fractional coefficient.
>
> [...]
Applied to https://git.u-boot-project.org/u-boot/custodians/u-boot-rockchip (u-boot-rockchip-2027.01), thanks!
[1/5] clk: rockchip: pll: drop misleading fout in rockchip_rk3588_pll_k_get()
https://git.u-boot-project.org/u-boot/custodians/u-boot-rockchip/-/commit/e5b3e6fd45ceff28a3cb9834809acacad82aa585
[2/5] clk: rockchip: pll: fix rounding of negative k in RK3588 frac PLL
https://git.u-boot-project.org/u-boot/custodians/u-boot-rockchip/-/commit/7a3ef6c21fdb4912779132e0dd93fc59da7d6357
[3/5] clk: rockchip: pll: fix RK3588 frac PLL result for k=-32768
https://git.u-boot-project.org/u-boot/custodians/u-boot-rockchip/-/commit/ffd377597b57bc83709a5d5200d0e15fdbbba5c6
[4/5] clk: rockchip: pll: let rockchip_rk3588_pll_k_get update m directly
https://git.u-boot-project.org/u-boot/custodians/u-boot-rockchip/-/commit/3bc88868c237b7b40d87d931474c5739f76b2d13
[5/5] clk: rockchip: pll: fix overflow and drop manual two's complement on RK3588/RK3576
https://git.u-boot-project.org/u-boot/custodians/u-boot-rockchip/-/commit/f75a3d96e1f33c1b8737018843b7bd5fc207b9d4
Best regards,
--
Quentin Schulz <[email protected]>