Re: [RESEND,v2,0/5] watchdog: report effective timeout

Simon Glass <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <CAFLszThdqj8hPL82RKe5secs1_Vg0N1fSNRcwBX0RuhfUCttzQ__31097.1624263161$1786748163$gmane$org@mail.gmail.com>
Hi Juuso,

On 2026-08-12T09:48:39, Juuso Rinta <[email protected]> wrote:

> The hardware still performs the actual clamping; max_timeout_ms only
> lets the uclass report the effective value in the start-path print.

Since the uclass now knows both the requested value and the
driver-reported maximum, would it be cleaner to have the uclass clamp
timeout_ms before calling ops->start(), rather than reporting a value
the driver may or may not honour? The sandbox driver has had to grow
its own clamp in patch 4 purely so the print path is testable. If the
uclass clamped, real drivers would never see an out-of-range value and
the sandbox change in patch 4 would not be needed. What do you think?

Regards,
Simon
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.