Re: [0/5] binman: add nxp_imx93cst etype for i.MX93 flash.bin signing
Jérémie Dautheribes via U-Boot <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Organization | Bootlin |
| Message-ID | <13c3fccd-1fd3-4ae2-a44a-84e00c382f33__21998.0216281087$1786981861$gmane$org@bootlin.com> |
Hi Simon, First, thank you for your thorough review! On 8/15/26 00:31, Simon Glass wrote: > Hi Jérémie, > > On 2026-08-14T17:07:09, Jérémie Dautheribes > <[email protected]> wrote: > >> Patch 1: introduces the new etype >> Patch 2: updates the imx93-u-boot.dtsi description to include the new >> signing nodes >> Patches 3-4: documentation >> Patch 5: adds test coverage > [..] >> The implementation is largely derived from the existing i.MX8M support, >> since the two share much of the same signing infrastructure. > > Given how close this is to nxp_imx8mcst, please say in the cover > letter whether you considered factoring out a common base class rather > than duplicating the etype, and why you decided against it. On second thought, I think it makes sense to factor out a common base class shared between the two etypes, so I'll do that for v2. Thanks! Best regards, Jérémie -- Jérémie Dautheribes, Bootlin Embedded Linux and Kernel engineering https://bootlin.com