Re: [PATCH 1/3] usb: ehci-vf: remove the code path for a build without DM_USB
Marek Vasut <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <71b7897e-b11d-4f9c-b3c0-e7eb23e26bae__47070.4958470137$1787198137$gmane$org@mailbox.org> |
On 8/19/26 11:37 AM, Mehmet Fide wrote: > From: Mehmet Fide <[email protected]> > > USB_EHCI_HCD selects DM_USB, so the !CONFIG_IS_ENABLED(DM_USB) branch of > this driver can never be selected. It also cannot compile: ehci_hcd_init() > calls ehci_vf_common_init() with one argument while the function takes > two, so the branch has been dead since the controller was added as a > second parameter. > > Remove it, together with the board_usb_phy_mode() hook that no board > implements and nothing else calls. > > Signed-off-by: Mehmet Fide <[email protected]> Could you please double-check that this is not used in SPL without DM_USB ?