Re: [PATCH v1] env: Fix compile error for envtools

On Fri, Aug 21, 2026 at 03:10:58PM +0200, Rasmus Villemoes wrote:
> On Tue, Jul 14 2026, Tom Rini <[email protected]> wrote:
> 
> > On Tue, Jul 14, 2026 at 03:04:42AM +0000, [email protected] wrote:
> >> > > I use master branch of OSS u-boot repo and meet the issue with below
> >> > > commands:
> >> > >
> >> > > make mx6qsabrelite_defconfig
> >> > > make -j8
> >> > > make tools envtools
> >> > 
> >> > What host distribution are you building on? And, <config.h> *must* come first
> >> > in the include list, for it to function correctly.
> >> 
> >> Host OS is Ubuntu 22.04.3 LTS.
> >> Toolchain is Arm GNU Toolchain 11.3.Rel1(arm-none-linux-gnueabihf-).
> >> Also tried Ubuntu 24.04.4 LTS and Arm GNU Toolchain 15.3.Rel1,
> >> the issue still happens.
> >
> > So, are you on an ARM host too? You aren't specifying where you are /
> > aren't using the ARM toolchain in the above. Thanks.
> 
> It doesn't matter what toolchain one uses. The mentioned commit does
> break "make envtools" for all our boards, building through Yocto. And
> when I build manually using my distro's cross-compiler, the same thing
> happens.
> 
> Note, it's not the board build itself that breaks, only the "make
> envtools", which I assume few people do these days.

I can't replicate this failure, is part of my problem. I get something
else entirely. Using the CI build containers:

$ make CROSS_COMPILE=/opt/gcc-15.2.0-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- mx6qsabrelite_defconfig tools envtools
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.[ch]
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
scripts/kconfig/conf  --syncconfig Kconfig
  UPD     include/config.h
  CFG     u-boot.cfg
[snip]
  HOSTCC  tools/env/crc32.o
In file included from tools/env/crc32.c:1:
tools/env/../../lib/crc32.c:12:10: fatal error: arpa/inet.h: No such file or directory
   12 | #include <arpa/inet.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.host:113: tools/env/crc32.o] Error 1
make[1]: *** [Makefile:2520: envtools] Error 2
make: *** [Makefile:362: __build_one_by_one] Error 2

So I don't even get to build that reported to fail to compile file, and
if I toss in a -k to make, I get a bunch of different failures. And if
instead I do "make tools-only_defconfig tools envtools" everything
builds. There is a use case here, and I assume it has to do with wanting
fw_setenv to have a specific default environment? Or something else?

-- 
Tom

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTzzqh0PWDgGS+bTHor4qD1Cr/kCgUCaohoVQAKCRAr4qD1Cr/k
CsjjAP9zt4VGiBuSlbhzVwwXxlNHrhSyzYMSFdduqnR9Z2RpLQD+M0y9T61/ntH7
/pNRVsp3CazIlJWJFmvVuKBlGQgIXwY=
=iNsr
-----END PGP SIGNATURE-----