Re: [PATCH v9 00/19] spacemit mmc driver

Hi Eric

On 11:54 Wed 19 Aug     , Eric Chung wrote:
> This series adds MMC support for the SpacemiT K1: an SDHCI platform
> driver, the SD card device-tree overlay, defconfig options, and SPL
> boot-device selection from the SoC strap/config registers. The SDHCI
> driver is usable in both SPL and U-Boot proper.
> 
> A flashing guide (doc/board/spacemit/k1-flash.rst) describes how to
> write images to eMMC.
> 
> ---
> Changes in v9:
> - spl: Enhance detection on booting from SD.
> - dts: Synched upstream DTS files for K1.
> - doc: Create SD card image from scratch.
> - mmc: Avoid to use CMD18 on SD card in SPL.
..
> - pinctrl: Drop "fix drive strength configuration".
Could you please explain why this patch is dropped?

It looks valid to me, also it fix a problem that setting drive strength
actually clear out other pin conf bits which lead to serious bug

-               clrsetbits_le32(addr, PAD_DRIVE, ds);
+               clrsetbits_le32(addr, PAD_DRIVE, FIELD_PREP(PAD_DRIVE, ds));

-- 
Yixun Lan (dlan)