Re: Fighting Safe for code coverage

Jeff Fearn <[email protected]> Mon, 6 Jun 2016 09:51:02 +1000
Newsgroups gmane.comp.bug-tracking.bugzilla.devel
Message-ID <[email protected]>

On 4/06/2016 10:10, Jeff Fearn wrote:
> On 4/06/2016 9:55 AM, Jeff Fearn wrote:
>> On 4/06/2016 9:42 AM, Jeff Fearn wrote:
>>> On 3/06/2016 10:21 PM, Dylan Hardison wrote:
>>>> What version of Devel::Cover and Safe? I can't reproduce here.
>>>>
>>>> perl -MSafe\ 9999
>>>> perl -MDevel::Cover\ 9999
>>>
>>> Safe 2.37
>>> Devel::Cover 1.17
>>> perl 5.20.3
>>>
>>> Oh nasty, I ran this on a clean upstream and it works fine, I guess I
>>> need to go diving in to our patches and extensions >_<
>>
>> Thanks for the pointer, I've isolated it to the ComponentWatching
>> extension we lifted from BMO. Haven't determined the exact cause yet,
>> but touch `extension/ComponentWatching/disabled` allows Devel::Cover to
>> run again.
>
> And solved, an unneeded reference to Bugzilla->bdh was added to the
> top of db_schema_abstract_schema which causes some insanity.
>
> Someone owes me a cider, Matt!

Turns out it's not Matt, it's DKL!

https://github.com/mozilla/webtools-bmo-bugzilla/commit/634f31d6c64894bcf2f0788525e9a9286e9de314

Cheers, Jeff.
-
To view or change your list settings, click here:
<https://lists.bugzilla.org/cgi-bin/mj_wwwusr?user=gcbd-developers-Uylq5CNFT+jYtjvyW6yDsg@public.gmane.org>