[[email protected]: Bug#280498: gnatsweb.pl: Wrong email addresses for PR 'responsible' persons]

--===============0934841176==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY"
Content-Disposition: inline


--Bu8it7iiRSEf40bY
Content-Type: multipart/mixed; boundary="JP+T4n/bALQSJXh8"
Content-Disposition: inline


--JP+T4n/bALQSJXh8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This PR and patch showed up in the Debian BTS.

--=20
Chad Walstrom <[email protected]>           http://www.wookimus.net/
           assert(expired(knowledge)); /* core dump */

--JP+T4n/bALQSJXh8
Content-Type: message/rfc822
Content-Disposition: inline

X-Envelope-From: chewie  Tue Nov  9 15:38:51 2004
Return-Path: <[email protected]>
X-Original-To: [email protected]
Delivered-To: [email protected]
Received: from chef.nerp.net [199.199.210.160]
	by localhost with IMAP (fetchmail-6.2.5)
	for chewie@localhost (single-drop);
	Tue, 09 Nov 2004 15:38:51 -0600 (CST)
Received: from spohr.debian.org (spohr.debian.org [128.193.0.4])
	by chef.nerp.net (Postfix) with ESMTP id DD301334F9
	for <[email protected]>; Tue,  9 Nov 2004 15:38:46 -0600 (CST)
Received: from debbugs by spohr.debian.org with local (Exim 3.35 1 (Debian))
	id 1CRdbt-0002iq-00; Tue, 09 Nov 2004 13:33:05 -0800
X-Loop: [email protected]
Subject: Bug#280498: gnatsweb.pl: Wrong email addresses for PR 'responsible'
	persons
Resent-From: Nadim Shaikli <[email protected]>
Resent-To: [email protected]
Resent-Cc: Chad Walstrom <[email protected]>
Resent-Date: Tue, 09 Nov 2004 21:33:04 UTC
Resent-Message-ID: <[email protected]>
X-Debian-PR-Message: report 280498
X-Debian-PR-Package: gnatsweb
X-Debian-PR-Keywords: patch
Received: via spool by [email protected] id=B.11000357606133
	(code B ref -1); Tue, 09 Nov 2004 21:33:04 UTC
Received: (at submit) by bugs.debian.org; 9 Nov 2004 21:29:20 +0000
Received: from sparks.vncu.com.0.18.216.in-addr.arpa (arabeyes.org)
	[216.18.0.60] by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CRdYG-0001ak-00; Tue, 09 Nov 2004 13:29:20 -0800
Received: by arabeyes.org (Postfix, from userid 1001)
	id DE1C299DF; Tue,  9 Nov 2004 13:31:52 -0800 (PST)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Nadim Shaikli <[email protected]>
To: Debian Bug Tracking System <[email protected]>
X-Mailer: reportbug 2.39
Date: Tue, 09 Nov 2004 13:31:52 -0800
Message-Id: <[email protected]>
Delivered-To: [email protected]
Resent-Sender: Debian BTS <[email protected]>
X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on chef.nerp.net
X-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,
	FORGED_YAHOO_RCVD,HTML_MESSAGE autolearn=no version=2.64
X-IMAPbase: 1087750457 13252
X-UID: 13252
X-Keywords: 
X-MD5-Checksum: 1af46e9dc2172a80a8845e7028de5547  -
Reply-To: [email protected]

Package: gnatsweb
Version: 4.00-1
Severity: normal
File: gnatsweb.pl
Tags: patch

Gnatsweb seems to assume that the default responsible people will have
the same email as the default domain which is not the case as is noted
in the 'responsible' file within the "gnats-adm" directory.  Gnatsweb
thus displays the wrong email addresses.  Some of our users also noted
that they'd rather the 'responsible' person's fullname instead of their
username.  Patch is noted below.

### Patch - Begin
--- gnatsweb.pl.orig	2004-11-05 12:09:49.000000000 -0800
+++ gnatsweb.pl	2004-11-05 15:33:04.000000000 -0800
@@ -2144,10 +2144,14 @@
 # if it's not a full address, $site_mail_domain is appended first
 sub make_mailto {
     my $string = shift;
-    if ($string !~ /@/) {
-	$string = qq*<a href="mailto:${string}${site_mail_domain}">$string</a>*;
+    my $addr = exists($responsible_address{$string}) ?
+	  $responsible_address{$string} : $string;
+    my $fullname = exists($responsible_fullname{$string}) ?
+	  $responsible_fullname{$string} : $string;
+    if ($addr !~ /@/) {
+	$string = qq*<a href="mailto:${addr}${site_mail_domain}">$fullname</a>*;
     } else {
-	$string = qq*<a href="mailto:$string">$string</a>*;
+	$string = qq*<a href="mailto:$addr">$fullname</a>*;
     }
     
     return $string;
### Patch - End

Hope this gets included.

 - Nadim

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux sina 2.4.22 #2 Thu Sep 18 20:47:45 PDT 2003 i686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8

Versions of packages gnatsweb depends on:
ii  apache [httpd]              1.3.29.0.1-3 Versatile, high-performance HTTP s
ii  apache2-mpm-prefork [httpd] 2.0.51-2     Traditional model for Apache2
ii  perl [libmime-base64-perl]  5.8.4-2      Larry Wall's Practical Extraction 
ii  perl-modules [libcgi-pm-per 5.8.4-2      Core Perl modules.

-- no debconf information

--JP+T4n/bALQSJXh8--

--Bu8it7iiRSEf40bY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBkUvyDMcLGCBsWv0RAnEgAJ0Yszy+n71NvcqlVdlclFM6Mxty+wCgsCQF
sVTNxEKqgcN+dkTOdUt337s=
=YkMt
-----END PGP SIGNATURE-----

--Bu8it7iiRSEf40bY--



--===============0934841176==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Bug-gnats mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-gnats

--===============0934841176==--